Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Adam Meehan

Adam Meehan

Not a member

Adam Meehan's latest activity

Tuesday, March 01 2011
6489 Fix before_type_cast for timezone aware datetime attributes was updated in Ruby on Rails
  • Adam Meehan
    Adam Meehan commented at 11:21 AM

    Another change to remove the reload arg on the timezone aware attribute read method. This argument is undocumented, untested and breaks the before_type_cast beh...
  • Adam Meehan
    Adam Meehan commented at 11:14 AM

    Reviewing this code and noticing a few comment about issues on the original commit from github, I realised the dup call on original_time is not necessary. There...
Monday, February 28 2011
6489 Fix before_type_cast for timezone aware datetime attributes was created in Ruby on Rails
  • Adam Meehan
    Adam Meehan created the ticket at 9:13 PM

    The change made to allow timezone aware datetime attributes support before_type_cast function does not work correctly. The test for the change does not exercise...
Thursday, February 10 2011
3973 before_type_cast not available for datetime fields was updated in Ruby on Rails
  • Adam Meehan
    Adam Meehan commented at 11:44 AM

    @Akira you're right I think. Driving me nuts!!

    Finally, patch attached.
  • Adam Meehan
    Adam Meehan commented at 11:34 AM

    The patch (bloody lighthouse!!)
  • Adam Meehan
    Adam Meehan commented at 11:32 AM

    I had my suspicions this patch was not working.

    After playing around I confirmed that tests were not touching the changed code at all. This is because time_zone...
Saturday, September 11 2010
5616 ActiveResource error parsing support for new JSON errors serialization format was created in Ruby on Rails
  • Adam Meehan
    Adam Meehan created the ticket at 11:37 AM

    ActiveResource has not been updated to support the current ActiveModel errors serialization format. This patch supports both the new and old formats.

    It also su...
5254 Rails 3RC's ActiveModel#as_json outputs array of message instead of hash of c... was updated in Ruby on Rails
5615 Support multiple errors per attribute in ActiveModel Errors JSON serialization was updated in Ruby on Rails
  • Adam Meehan
    • Tag changed from activemodel to json encoding as_json, activemodel, errors, patch, serialization
    by Adam Meehan at 11:14 AM
  • Adam Meehan
    Adam Meehan created the ticket at 11:13 AM

    The current errors json serialization does not work for mutiple errors on a attribute. It returns duplicate keys for subsequent errors for that attribute. This ...