Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Xavier Noria

Xavier Noria

Member of 1 project: Ruby on Rails

Xavier Noria's latest activity

Sunday, November 30 2008
1495 Normalize author names in CHANGELOGs was updated in Ruby on Rails
  • Xavier Noria
    Xavier Noria commented at 1:58 AM

    Hi Chris, please just send me an email to fxn at hashref dot com. I'll update both the gists and this ticket.

    Also, if someone wants to add some normalization o...
  • Xavier Noria
    Xavier Noria created the ticket at 12:22 AM

    This patch normalizes author names in CHANGELOGs according to the map in http://gist.github.com/23458. That hash was built with many contributions from people i...
Saturday, September 06 2008
922 has_many through transaction rollback was updated in Ruby on Rails
  • Xavier Noria
    Xavier Noria commented at 4:51 AM

    And yet another revision.
  • Xavier Noria
    Xavier Noria commented at 4:36 AM

    Touched a couple of details in the original diff, here's an update.
  • Xavier Noria
    Xavier Noria commented at 4:31 AM

    OK, here's a fix. We wrap the update_attribute* family in transactions.
  • Xavier Noria
    Xavier Noria commented at 2:12 AM

    I think I see the problem.

    The setter category_ids= updates the associated categories in the database right away.

    On the other hand update_attributes is impleme...
Sunday, August 31 2008
922 has_many through transaction rollback was updated in Ruby on Rails
  • Xavier Noria
    Xavier Noria commented at 9:20 PM

    In edge, if any validation fails there's a rollback of the transaction that wraps save (that's since #891).

    Could you please test if that solves this issue?
Sunday, August 24 2008
891 let cancels from before filters issue a ROLLBACK was created in Ruby on Rails
  • Xavier Noria
    Xavier Noria created the ticket at 2:26 AM

    The AR methods save, save!, and destroy run within a transaction that wraps their entire callback chain.

    Before filters may cancel the action returning false. ...
Wednesday, August 20 2008
865 fix count_records was updated in Ruby on Rails
  • Xavier Noria
    Xavier Noria commented at 11:55 AM

    Yeah, the test assumes size1 is correct because there are unit tests for #size in test_build and test_collection_size_after_building.
  • Xavier Noria
    Xavier Noria commented at 12:22 AM

    Patch updated with Fred's proposal. That one is better because we certainly can assert loaded anyway.