Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Brian Morearty's latest activity

Wednesday, March 30 2011
5412 [Patch] Rails schema_format :sql should behave like schema_format :ruby was updated in Ruby on Rails
Tuesday, March 29 2011
6421 Deprecate 'escape' parameter/option in three helper functions was updated in Ruby on Rails
  • Brian Morearty
    Brian Morearty commented at 5:56 AM

    Hi again,

    Sorry to bump this but here goes: is there anything I can do to help get this deprecation of the 'escape' parameter done and approved? It's so close. ...

Thursday, February 24 2011
6421 Deprecate 'escape' parameter/option in three helper functions was updated in Ruby on Rails
  • Brian Morearty
    Brian Morearty commented at 12:40 AM

    Hey, Santiago, no problem. I don't even know how you find time to do everything you do. I know reviewing patches is time-consuming. :-)

    It's not a big deal if i...

Wednesday, February 23 2011
6421 Deprecate 'escape' parameter/option in three helper functions was updated in Ruby on Rails
  • Brian Morearty
    Brian Morearty commented at 9:07 PM

    Hi,

    I was wondering if there's anything I can do to help push this along. I saw that a 3.0.5rc1 was pushed out today, and the original plan was to put the 'esca...

Friday, February 18 2011
6421 Deprecate 'escape' parameter/option in three helper functions was updated in Ruby on Rails
  • Brian Morearty
    Brian Morearty commented at 5:25 PM

    Hi Santiago,

    Thanks again for the help! Here is a new patch for the master branch. This is what I did:

    Re: your first point, you are right--the example wasn't g...

  • Brian Morearty
    Brian Morearty commented at 12:54 AM

    Thanks for taking a detailed look at it, Santiago.

    +      #   tag("img", {:src => "open & shut.png".html_safe})
    

    You make a good point. I'll change it to somet...

Thursday, February 17 2011
6421 Deprecate 'escape' parameter/option in three helper functions was updated in Ruby on Rails
  • Brian Morearty
    Brian Morearty commented at 7:11 PM

    and this is the patch for the master branch.

  • Brian Morearty
    Brian Morearty commented at 7:11 PM

    Sure. This is the patch for the 3-0-stable branch...

Sunday, February 13 2011
6421 Deprecate 'escape' parameter/option in three helper functions was updated in Ruby on Rails
  • Brian Morearty
    Brian Morearty commented at 10:11 PM

    Cool, so this patch is done, tested, and ready for you to apply. The 3 helper functions mentioned above (FormTagHelper#text_area_tag, TagHelper#content_tag, and...

  • Brian Morearty
    Brian Morearty commented at 12:37 AM

    I'm writing a patch with deprecation notices for 3-0-stable. But I have a question: what branch do I use for the post-deprecation code? (The code that no longer...