Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Ryan McGeary

Ryan McGeary

Not a member

Ryan McGeary's latest activity

Monday, October 18 2010
5444 rescue_action_in_public! no longer works was updated in Ruby on Rails
  • Ryan McGeary
    Ryan McGeary commented at 12:00 AM

    Is rescue_action_in_public! intended to be deprecated?

    I'm willing to spend some time looking into a fix for this, but I'd like to know the direction that Rails...
Monday, August 03 2009
better_time_zone_offset_defaults.diff was uploaded by Ryan McGeary at 5:46 PM to #2985, Ruby on Rails
Download
better_time_zone_offset_defaults.diff(9 kb)
2985 Return the most popular TimeZone given a UTC offset was updated in Ruby on Rails
  • Ryan McGeary
    Ryan McGeary commented at 2:53 AM

    I'd take a patch which made it easier to rejuggle those timezones or assign defaults for an offset, but that's all.

    That sounds like configuration over conven...
  • Ryan McGeary
    Ryan McGeary commented at 2:13 AM

    Koz, I understand the concern, but a lot of apps guess the wrong time zone for a majority of their users because of the default behavior that's in ActiveSupport...
  • Ryan McGeary
    Ryan McGeary created the ticket at 12:50 AM

    Regarding ActiveSupport::TimeZone, when looking up a time zone from a UTC offset, the returned value is rarely what is expected. Offsets have multiple time zone...
Sunday, January 25 2009
1781 Patch to BelongsToAssociationTest to support handling of empty strings in Oracle was updated in Ruby on Rails
Saturday, January 24 2009
1758 Patch to adapter_test cases so that the tests work for all adapters was updated in Ruby on Rails
  • Ryan McGeary
    Ryan McGeary commented at 10:50 PM

    +1, but Oracle still sucks :-)

    I think this patch actually improves the readability of the tests too, because it now asserts the intention of avoiding the sql i...
Friday, November 14 2008
683 Problem with RailsSanitize.white_list_sanitizer.sanitize was updated in Ruby on Rails
  • Ryan McGeary
    Ryan McGeary commented at 3:32 PM

    iGEL, I disagree. The purpose of the sanitize method is to sanitize HTML input. The ampersand entities are valid HTML. When displayed, they should display the e...
Friday, October 17 2008
683 Problem with RailsSanitize.white_list_sanitizer.sanitize was updated in Ruby on Rails
  • Ryan McGeary
    Ryan McGeary commented at 3:41 AM

    +1 on antonmos's changes. Here's a formatted patch that incorporates the changes to comply with the Rails contribution guidelines.
Thursday, October 09 2008
374 Sanitize treats & entity in URI incorrectly was updated in Ruby on Rails
  • Ryan McGeary
    Ryan McGeary commented at 12:54 AM

    I think #683 is a dupe of this, and it has more information. Should we close this ticket out?