Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

oleg dashevskii

oleg dashevskii

Not a member

oleg dashevskii's latest activity

Thursday, April 14 2011
5412 [Patch] Rails schema_format :sql should behave like schema_format :ruby was updated in Ruby on Rails
Wednesday, September 01 2010
5441 [PATCH] ActiveRecord::Calculations#count doesn't allow table names in column_... was updated in Ruby on Rails
  • oleg dashevskii
    oleg dashevskii commented at 4:40 AM

    Neeraj, it works for me (git am < file).
Tuesday, August 31 2010
5441 [PATCH] ActiveRecord::Calculations#count doesn't allow table names in column_... was updated in Ruby on Rails
  • oleg dashevskii
    • Title changed from ActiveRecord::Calculations#count doesn't allow table names in column_name argument to [PATCH] ActiveRecord::Calculations#count doesn't allow table names in column_name argument
    • Tag changed from 3.0.0.rc2, :select, calculations to activerecord 3.0, 3.0.0.rc2, :select, calculations, patch
    by oleg dashevskii at 6:12 PM

    I fixed the bug with a rather brute-force style. This @klass.send(:relation) thing apparently is a mess.

    Patch is attached.
Thursday, August 26 2010
5442 [PATCH] Model.has_many_through_association.find(id) returns a read-only record was updated in Ruby on Rails
  • oleg dashevskii
    • Tag changed from activerecord rails3, find_one, has_many_through_association, readonly to activerecord rails3, find_one, has_many_through_association, patch, readonly
    by oleg dashevskii at 5:31 AM
  • oleg dashevskii
    • Title changed from Model.has_many_through_association.find(id) returns a read-only record to [PATCH] Model.has_many_through_association.find(id) returns a read-only record
    by oleg dashevskii at 5:30 AM

    This is a rather obscure bug. I'm glad to say I finally traced it down. ActiveRecord::QueryMethods#build_select wasn't resetting @implicit_readonly since it was...
5436 RC1 to RC2 regression : multilines where conditions autojoin with "AND" was updated in Ruby on Rails
Wednesday, August 25 2010
5442 Model.has_many_through_association.find(id) returns a read-only record was updated in Ruby on Rails
  • oleg dashevskii
    oleg dashevskii commented at 5:21 PM

    Paul, this test is noop, since :people fixture isn't loaded and empty array passes the test. I've changed it (see the patch) and it still passes! So the problem...
  • oleg dashevskii
    oleg dashevskii commented at 10:11 AM

    I've added a test proving this bug.
5441 ActiveRecord::Calculations#count doesn't allow table names in column_name arg... was updated in Ruby on Rails
  • oleg dashevskii
    oleg dashevskii commented at 5:19 PM

    Since simple count (not grouped) works, I looked into its implementation:

        def execute_simple_calculation(operation, column_name, distinct) #:nodoc:
      c...
  • oleg dashevskii
    oleg dashevskii commented at 9:53 AM

    I made up a pair of tests which prove the bug.