pupeno@pupeno.com

This is the relevant context:

class User < ActiveRecord::Base
  has_and_belongs_to_many :clocks
  has_many :runs, :through => :clocks
  has_many :user_runs
  #...

I'll give you more context information bellow, but first, let me show you some active records call.

First a simple "let's get a clock":

    @user.clocks.find(@...

Matt,

Yes, I can do that. Wouldn't that remove authorship from Paul Barry, and if so, is it acceptable for me to do it?

Oh, right, I only worked in Rails 3 for this patch.

New patch that applies cleanly (I actually couldn't find the conflict) and puts the add_index inside the no exceptions zone.

Étienne, oh, got it regarding assert_nothing_raised. I'll fix it.

But the issue was the name of the table, not the name of the index. What wasn't being escaped ...

Étienne,

Paul Barry added the assert_nothing_raised block. I'll look into the conflict.

Regarding MigrationTest, I should add the test here: activerecord/test/c...

Thanks Paul, I just updated my repo with your patch.

Oh, and it's also in this branch: http://github.com/pupeno/rails/tree/remove_index_from_values It's this commit: http://github.com/pupeno/rails/commit/13f98698...

I'm attaching the patch that fixes this issue. It contains a test that shows the issue. I'm quite sure the way I wrote the test is not good, I've created anothe...