Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Tammer Saleh's latest activity

Thursday, November 20 2008
1423 Optional Exception on Mass-assignment of Protected Attributes was updated in Ruby on Rails
  • Tammer Saleh
    Tammer Saleh commented at 8:44 PM

    +1

    The ARes argument is the first one I've heard for not raising on an attempt to mass-update a protected attribute, and it seems like somewhat of an edge case....

Wednesday, June 25 2008
484 Remove Symbol#to_proc from framework code was updated in Ruby on Rails
  • Tammer Saleh
    Tammer Saleh commented at 3:13 PM

    bq. I don't think too much readability is sacrificed here considering this is framework code, not application code.

    I disagree with that argument. Readabili...

  • Tammer Saleh
    Tammer Saleh commented at 2:59 PM

    I'd like to see some metrics on how much of a performance boost this produces.

  • Tammer Saleh
    Tammer Saleh commented at 2:56 PM

    -1

    I'd argue that the slight performance increase isn't worth the readability hit introduced by this patch. Take, for example, this snippet:

    filter_chain.se...
  • Tammer Saleh
    Tammer Saleh commented at 2:42 PM

    I don't understand the reason for this patch. Can you explain further?

Friday, June 20 2008
461 Fixed polymorphic_url to be able to handle singleton resources. was updated in Ruby on Rails
  • Tammer Saleh
    Tammer Saleh commented at 10:38 PM

    Fixed bug in polymorphic_url([record, :singular]).

  • Tammer Saleh
    • Assigned user set to Jeremy Kemper
    by Tammer Saleh at 9:43 PM
  • Tammer Saleh
    • Assigned user cleared.
    by Tammer Saleh at 9:17 PM

    New patch that improves documentation and removes accidentally included comments.

  • Tammer Saleh
    Tammer Saleh commented at 8:53 PM

    Attached patch.

  • Tammer Saleh
    Tammer Saleh created the ticket at 8:40 PM

    The polymorphic_url helper does not handle singleton resources correctly. This patch allows you to specify singular resources by listing them as symbols (much...