Murray Steele's profile

- Tag changed from inverse_of activerecord patch to activerecord, inverse_of, patch
by Murray Steele at 11:30 PM
The patch is complete, but it might want some work or thought about the API it exposes. Or more tests - I'm not sure about the testing strategy.
Murray Steele created the ticket at 11:28 PM
Change ActiveRecord so that if the model doesn't specify an explicit :inverse_of option AR will try to guess and give the model the benefits of :inverse_of. In ...

Murray Steele commented at 4:15 PM
In response to Eloy's comments on IRC, the attached patch now makes polymorphic_inverse_of on Reflection throw an InverseOfAssociationNotFoundError if the suppl...
Murray Steele commented at 12:31 PM
One concern I have is that a polymorphic belongs_to using :inverse_of will never throw an InverseOfAssociationNotFoundError if the supplied :inverse_of doesn't ...
Murray Steele commented at 12:27 PM

George's above patch is good. However, attached is a new patch that:

a) includes George's patch tweaked to apply cleanly on top of my extra tests patch for #351...

Murray Steele commented at 12:34 PM
Just reminding myself that when #3513 and/or #3520 are applied to master, we should revisit this patch to backport them to 2-3-stable if this patch hasn't alrea...
Murray Steele commented at 10:06 AM
I clearly meant #2815.
Murray Steele commented at 10:04 AM
Updated the patch to also include the patch committed to master that resolves [2815].

- Assigned user set to Michael Koziarski
by Murray Steele at 11:41 AM
Oops! Didn't mean to unassign this.
- Assigned user cleared.
by Murray Steele at 11:41 AM

I'm attaching a patch that should go on top of this one to:

a) add more tests for the various ways you can assign things (bang methods, <<, =, replace) for all ...