Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Tim Haines

Tim Haines

Not a member

Tim Haines's latest activity

Wednesday, September 03 2008
957 Generate form_authenticity_token correctly when using CookieStore and Secret ... was updated in Ruby on Rails
  • Tim Haines
    • Title changed from Ignore secret when Cookie Store is used to Generate form_authenticity_token correctly when using CookieStore and Secret present
    by Tim Haines at 9:37 AM
  • Tim Haines
    Tim Haines commented at 9:25 AM

    Requests are made via the module that's included -> include RequestForgeryProtectionTests This is the same pattern that is used for the other request_forgery_pa...
Tuesday, September 02 2008
957 Ignore secret when Cookie Store is used was updated in Ruby on Rails
  • Tim Haines
    Tim Haines commented at 9:18 PM

    This patch (or one like it) also has the side benefit of being able to simplify the generated code for ActionController. The :secret could be uncommented by def...
  • Tim Haines
    Tim Haines created the ticket at 1:26 PM

    Currently if you're using the CookieStore, and accidentally call protect_from_forgery with a :secret param, then the form_authenticity_token won't be generated ...
Friday, August 29 2008
931 assert_select_rjs has bad message when assert show/hide fails was updated in Ruby on Rails
  • Tim Haines
    • Tag changed from 2.1, actionpack, assertions, edge to 2.1, actionpack, assertions, edge, patch, tested, tests
    by Tim Haines at 11:20 AM

    Patch attached. Also improved error messages for :toggle and :remove.

    Quite simple.
  • Tim Haines
    Tim Haines created the ticket at 1:06 AM

    In test/spec: response.should have_rjs(:hide, 'subscribe')

    When error in controller: page.hide 'subscribe_opps_typo_here'

    The error message returned my assert_s...
Thursday, August 28 2008
920 TestUploadFile.content_type should be writable was created in Ruby on Rails
  • Tim Haines
    Tim Haines created the ticket at 2:05 AM

    Request.UploadedFile has a writable content_type. This is useful as the content_type needs to be set manually when uploading via swfUpload.

    TestUploadFile cur...
Monday, August 18 2008
812 _changed? doesn't work for attribute aliases was updated in Ruby on Rails
  • Tim Haines
    Tim Haines commented at 12:09 AM

    +1

    Thanks for writing this patch Rich. I've learnt a lot from reading through it and reproducing it - my patch wouldn't have been this clean.
Wednesday, August 13 2008
812 _changed? doesn't work for attribute aliases was updated in Ruby on Rails
  • Tim Haines
    • Tag changed from activerecord, enhancement to 2.1, activerecord, edge, enhancement
    by Tim Haines at 12:24 AM

    Opps, that formatting didn't work so well.

    I took a look at creating a patch for this, but was unsure if the alias_attribute method should simply define anothe...
  • Tim Haines
    Tim Haines created the ticket at 12:21 AM

    If you define an attribute alias like so:

    alias_attribute :name_for_cache, :name

    Then run the following:

    u.name = "bob" => "bob" u.name_changed? => true u....