Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Martin Gamsjaeger (snusnu)

Martin Gamsjaeger (snusnu)

Member of 1 project: Ruby on Rails

Martin Gamsjaeger (snusnu)'s latest activity

Monday, June 07 2010
4768 [PATCH] Makes #content_tag_as_string respect the "escape" parameter on content was updated in Ruby on Rails
Friday, June 04 2010
4768 [PATCH] Makes #content_tag_as_string respect the "escape" parameter on content was created in Ruby on Rails
  • Martin Gamsjaeger (snusnu)
    Martin Gamsjaeger (snusnu) created the ticket at 6:22 PM

    Hey, I noticed that currently the escape parameter gets completely ignored for the actual content given to #content_tag_as_string. This basically means that I c...
Thursday, June 03 2010
3559 Problem with XSS escape in select_* (eg: select_month) helpers was updated in Ruby on Rails
  • Martin Gamsjaeger (snusnu)
    Martin Gamsjaeger (snusnu) commented at 10:19 PM

    I've also added this PATCH link to #4728 and #4762 . Not sure it applies to any or all of them, but I'm looking through tickets that seem somehow related. Here'...
4728 Form Helper Escaping Problem was updated in Ruby on Rails
4762 url_for :escape parameter is ignored was updated in Ruby on Rails
  • Martin Gamsjaeger (snusnu)
    Martin Gamsjaeger (snusnu) commented at 10:09 PM

    While this maybe isn't the exact issue Jan encountered, I noticed something similar, where #content_tag_as_string completely ignores the escape param on the con...
Thursday, March 18 2010
4220 [PATCH] AS datetime conversions should require AS time conversions was created in Ruby on Rails
  • Martin Gamsjaeger (snusnu)
    Martin Gamsjaeger (snusnu) created the ticket at 5:42 PM

    This is necessary because DateTime#to_formatted_s uses Time::DATE_FORMATS which is defined in active_support/core_ext/time/conversions.rb

    Patch can be found at:...
4207 [PATCH] AS output_safety should require AS singleton_class was updated in Ruby on Rails
Wednesday, March 17 2010
4207 [PATCH] AS output_safety should require AS singleton_class was created in Ruby on Rails
  • Martin Gamsjaeger (snusnu)
    Martin Gamsjaeger (snusnu) created the ticket at 6:17 PM

    active_support/core_ext/string/output_safety.rb references the #singleton_class method so it should require the AS file that defines that method.

    Patch can be f...
Thursday, January 28 2010
3608 OrderedHash serialization doesn't work in AR was updated in Ruby on Rails
  • Martin Gamsjaeger (snusnu)
    • State changed from committed to incomplete
    by Martin Gamsjaeger (snusnu) at 1:10 AM

    Jeremy,

    OrderedHash now requires yaml, and in order to be properly cherry pickable, ordered_hash.rb should require 'yaml'. (My datamapper sample app won't boot ...
Wednesday, January 27 2010
3608 OrderedHash serialization doesn't work in AR was updated in Ruby on Rails
  • Martin Gamsjaeger (snusnu)
    • State changed from incomplete to verified
    by Martin Gamsjaeger (snusnu) at 11:04 PM

    Yes! Now all dm-core and dm-more specs pass with active_support :) Also, active_support tests pass for me. I should probably add that I haven't tested the scena...