Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Jeffrey Hardy's latest activity

Thursday, June 24 2010
4947 rake db:migrate:status was updated in Ruby on Rails
  • Jeffrey Hardy
    Jeffrey Hardy commented at 10:41 PM

    Not quite the same thing, but we do have rake db:version.

    $ rake db:version
    Current version: 20100419141336
    
Friday, January 08 2010
3671 Allow AR::Schema's migrations_path to be overwritten by subclasses was created in Ruby on Rails
  • Jeffrey Hardy
    Jeffrey Hardy created the ticket at 9:05 PM

    Extracts the hard-coded migrations path so it can be customized by subclasses. This is useful when you have a separate schema and migrations using a different c...

Thursday, October 15 2009
3379 Tiny refactor of FormTagHelper#extra_tags_for_form was created in Ruby on Rails
  • Jeffrey Hardy
    Jeffrey Hardy created the ticket at 5:45 AM

    Tiny refactor of FormTagHelper#extra_tags_for_form

    • removes a dead comment justifying an impossible case
    • pulls out generation of the method/token tags so we can...
Wednesday, October 14 2009
3375 CookieJar#delete should return the key's value, consistent with a Hash was created in Ruby on Rails
  • Jeffrey Hardy
    Jeffrey Hardy created the ticket at 5:37 AM

    ActionController::CookieJar is a Hash, but #delete differs from that of its superclass:

    cookies[:foo] = 'bar'
    cookies.delete(:foo) # => ["foo=; path=/; expires...
Monday, October 05 2009
3333 MessageVerifier#verify should raise InvalidSignature when the signature is blank was created in Ruby on Rails
  • Jeffrey Hardy
    Jeffrey Hardy created the ticket at 2:35 PM

    This patch modifies MessageVerifier#verify to raise InvalidSignature when the given signature is blank.

    Before this patch:

    >> ActiveSupport::MessageVerifier.ne...
Wednesday, September 02 2009
3135 Don't try to log protected attribute removal if there's no logger defined was created in Ruby on Rails
  • Jeffrey Hardy
    Jeffrey Hardy created the ticket at 5:14 PM

    When mass-assigning protected attributes, AR will log a warning. This causes an error if there's no logger defined. In other places where we use AR::Base.logger...

Friday, August 28 2009
3114 Remove class_inheritable_attributes test from AR, already covered by AS tests was created in Ruby on Rails
  • Jeffrey Hardy
    Jeffrey Hardy created the ticket at 1:51 PM

    The Active Record test suite contains a case for the Class extension class_inheritable_attributes. This is an old test case that has since been (more thoroughly...

Thursday, August 27 2009
3107 Don't abort early when running default AR tests was created in Ruby on Rails
  • Jeffrey Hardy
    Jeffrey Hardy created the ticket at 7:13 PM

    The default AR test task runs tests for mysql, sqlite3, and postgresql. If one of the tasks fails, subsequent tasks won't be run. This patch makes it so all tes...

Wednesday, August 26 2009
3104 Fixture columns should be quoted by the appropriate connection was created in Ruby on Rails
  • Jeffrey Hardy
    Jeffrey Hardy created the ticket at 8:11 PM

    AR::Fixtures.create_fixtures(...) { Custom.connection } will quote columns using AR::Base.connection rather than the custom connection. This is a problem when A...

3103 Eliminate Regexp test warnings was created in Ruby on Rails
  • Jeffrey Hardy
    Jeffrey Hardy created the ticket at 7:56 PM

    Subvert 'ambiguous first argument' warnings from RegexpExtAccessTests#test_multiline by using assert_equal.

    Ruby warns when a Regexp literal with a modifier opt...