Stefan Kaes

I mean, the second is simpler, of course

so? the first regexp can be transformed into the second, is simpler, semantically equivalent and stops the warning. why not apply the fix?

ruby 1.9 complains about some regexp being too complex:

activesupport/lib/active_support/dependencies.rb:510: warning: nested repeat operator + and ? was repl...

templates are recompiled every time.

attached path fixes this problem.

I also added tests to verify the desired behavior.

For testability I needed to refact...

Observers should not modify observed classes by defining an empty after_find method on the observed class.

First, it's evil to silently add a method.

Second,...

without the .exe magic the correct executable will sometimes not be found on windows. the problem is that some installations add a program.bat file alongside p...

+1. I use this all the time.