Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

Andrew Selder

Andrew Selder

Web Developer · Not a member

Andrew Selder's latest activity

Wednesday, April 27 2011
2188 Encoding error in Ruby1.9 for templates was updated in Ruby on Rails
  • Andrew Selder
    Andrew Selder commented at 8:12 PM

    I've updated the normalize parameters portion of joost's patch.

    This checks to make sure that the parameter is acutally valid in the UTF-8 encoding. If it's not...
Thursday, December 09 2010
3446 tables_in_string matches literal string containing dot was updated in Ruby on Rails
  • Andrew Selder
    Andrew Selder commented at 4:25 AM

    After talking to some of the guys over on the core mailing list, this tables_in string was a temporary hack in the move to preloading. It will probably be comin...
  • Andrew Selder
    • Tag changed from 2.3.10, 3.0.3, active_record, patch, tables_in_string, verified to 2.3.10, 3.0.3, active_record, tables_in_string
    by Andrew Selder at 2:42 AM

    Jeremy Evans found a case where the regex doesn't work (embedded escaped quote in literal).

    I'll have the regex fixed and new patches up shortly.
  • Andrew Selder
    Andrew Selder commented at 1:16 AM

    state:resolved
  • Andrew Selder
    • Tag changed from 2.3.10, 3.0.3, active_record, patch, tables_in_string to 2.3.10, 3.0.3, active_record, patch, tables_in_string, verified
    by Andrew Selder at 1:15 AM
  • Andrew Selder
    • Tag changed from 2.3.10, 3.0.3, active_record, patch, tables_in_string, verified to 2.3.10, 3.0.3, active_record, patch, tables_in_string
    by Andrew Selder at 1:15 AM

    readding patches with the ticket update keyword stuff in commit comment
2 earlier changes…
  • Andrew Selder
    • Tag changed from 2.3.10, 3.0.3, active_record, tables_in_string to 2.3.10, 3.0.3, active_record, patch, tables_in_string
    by Andrew Selder at 12:55 AM

    Let's actually try attaching this time.
  • Andrew Selder
    Andrew Selder commented at 12:50 AM

    Here are a couple of patches against master and 2-3-stable.

    It implements the regex I mentioned above.
Wednesday, December 08 2010
3446 tables_in_string matches literal string containing dot was updated in Ruby on Rails
  • Andrew Selder
    Andrew Selder commented at 11:36 PM

    Simon's regex above is not sufficient unfortunately.

    Two problems:

    1. The first gsub's pattern is greedy, so if you have multiple literals table names can get mis...
  • Andrew Selder
    • Tag set to 2.3.10, 3.0.3, active_record, tables_in_string
    • Importance changed from to
    by Andrew Selder at 11:15 PM

    This is still an open issue in ActiveRecord 3.0.3 and 2.3.10

    bad = "((((((LOWER(events.name) LIKE '%ga.fs%')))) AND (events.delete_flag = 0)) AND (events.date >...