Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Josh Sharpe

Josh Sharpe

Not a member

Josh Sharpe's latest activity

Saturday, August 08 2009
2489 Enumerable#sum should not rely on size was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 5:40 AM

    +1, patch applies, tests pass, and makes sense to me
2558 Support for :joins in ActiveRecord::Base#update_all was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 3:33 AM

    The idea makes sense, but the patch doesn't apply:

    Patch does not have a valid e-mail address.
2650 Added previous_changes to ActiveRecord::Dirty was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 3:25 AM

    This patch doesn't apply cleaning for me. I like the idea though.
2630 Adding a validates_with method was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 3:04 AM

    Cool idea. It would make sense for Observers and Validators to function the same way, since they both have the same idea of moving functionality out of the base...
2944 Titleize doesn't take all-uppercase words into account was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 2:41 AM

    verified and +1
    This has always bugged me!
2774 ActiveRecord tests with the same name was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 2:20 AM

    --test_find_all_with_limit Was previously testing :order clause when it shouldn't be

    --test_find_all_with_prepared_limit_and_offset Having specifically 3 Entran...
  • Josh Sharpe
    Josh Sharpe commented at 2:15 AM

    Verified that there are duplicate tests going on here -- but I would take this patch a but further:
1255 time.end_of_day not entirely accurate was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 1:46 AM

    The patch applies successfully and all tests pass.

    The tests look good, and the new functionality makes sense to me.

    +1
Saturday, July 11 2009
2719 has_many :through should work if the join model uses has_one relationship was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 11:22 PM

    This patch seems to work for me, but I really don't know enough about the inner workings of associations to be sure.
Thursday, July 09 2009
2852 accepts_nested_attributes_for creating new associated record when one already... was updated in Ruby on Rails
  • Josh Sharpe
    Josh Sharpe commented at 7:42 PM

    @Jose, Would you be strongly opposed if has_one returned the current association and you had to pass _delete => true in order to delete this record?

    I still fee...