Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Martin Eisenhardt

Martin Eisenhardt

Research assistant, soon-to-be Senior Dev · Not a member

Martin Eisenhardt's latest activity

Sunday, May 18 2008
195 Convenience methods for time zones outside the U.S. was updated in Ruby on Rails
Friday, May 16 2008
195 Convenience methods for time zones outside the U.S. was updated in Ruby on Rails
  • Martin Eisenhardt
    Martin Eisenhardt commented at 3:19 PM

    OK, I got the point: This functionality is better implemented in an i18n plugin. No worries.

    But: You should really think about what kind of impression it mak...
Thursday, May 15 2008
195 Convenience methods for time zones outside the U.S. was updated in Ruby on Rails
  • Martin Eisenhardt
    Martin Eisenhardt commented at 4:25 PM

    Hi Geoff,

    ad 1.) I agree that a Pacific time zone group is probably nothing that will be used very much. I do see much uses for european_zones or asian_zones....
  • Martin Eisenhardt
    Martin Eisenhardt commented at 10:24 AM

    Hello Star Trader,

    thank you for the review and valuable input. I do agree that further discussion as to which time zones shall be grouped together is necessa...
199 Use lazy evalution and caching for us_zones in TimeZones was updated in Ruby on Rails
  • Martin Eisenhardt
    Martin Eisenhardt commented at 3:34 PM

    Hi Joshua,

    thank you for the advice. It is the same I had in mind. Together with this comment, I upload an updated patch the pre-computes a US_ZONES constant,...
  • Martin Eisenhardt
    Martin Eisenhardt commented at 2:55 PM

    While regular expressions are by far the fastest way to search for patterns, they nevertheless are slow compared to using pre-computed values.

    I really do lik...
  • Martin Eisenhardt
    Martin Eisenhardt commented at 12:02 PM

    Hi Pratik, thank you for your review and comment.

    Ad 1.) OK, I can understand that this does not meet your personal coding standard, or the coding standard of...
Wednesday, May 14 2008
199 Use lazy evalution and caching for us_zones in TimeZones was created in Ruby on Rails
  • Martin Eisenhardt
    Martin Eisenhardt created the ticket at 7:45 PM

    The us_zones convenience method in TimeZone generates the list of TimeZone objects in the U.S. every time it is called. This is inefficient, especially in appl...
195 Convenience methods for time zones outside the U.S. was created in Ruby on Rails
  • Martin Eisenhardt
    Martin Eisenhardt created the ticket at 6:38 PM

    In the TimeZone class in ActiveSupport, there is a convenience method us_zones that dynamically creates a list of all time zones for the U.S.

    As is easy to se...