Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Adam Keys

Adam Keys

Rubyist/Raconteur · Not a member

Adam Keys's latest activity

Sunday, May 23 2010
4597 Queries using limits and punctuation in order clauses generate invalid SQL was updated in Ruby on Rails
  • Adam Keys
    Adam Keys commented at 12:29 AM

    +1

    I switched my bundle to use your fork of arel and, with your patch, everything is passing.

    Thanks!
Friday, May 21 2010
4597 Queries using limits and punctuation in order clauses generate invalid SQL was updated in Ruby on Rails
  • Adam Keys
    Adam Keys commented at 8:59 PM

    I applied the patch above and got one failure when I ran the PostgreSQL relation tests:

      1) Error:
test_finding_with_complex_order_and_limit(RelationTest):
Ac...
Tuesday, May 18 2010
4597 Queries using limits and punctuation in order clauses generate invalid SQL was updated in Ruby on Rails
  • Adam Keys
    • Assigned user set to Santiago Pastorino
    by Adam Keys at 3:54 PM

    Santiago, could you please review the most recent testcase attached above and clear the invalid flag on this ticket? I believe this is a bonafide bug.
Saturday, May 15 2010
4597 Queries using limits and punctuation in order clauses generate invalid SQL was updated in Ruby on Rails
  • Adam Keys
    Adam Keys commented at 9:09 PM

    Here's a better testcase. Remove the limit and the query is fine but the assert fails. Leave it in and the query is invalid.
  • Adam Keys
    Adam Keys commented at 8:49 PM

    The reason I believe this is a bug is that it works when there is no limit clause. Removing it produces this valid query:

    SELECT     "tags"."id" AS t0_r0, "tag...
  • Adam Keys
    Adam Keys commented at 4:02 PM

    Sure. Attached is a patch to add the test case and the result I get when run against PostgreSQL. I ran this against a recent clone of master.
Friday, May 14 2010
4597 Queries using limits and punctuation in order clauses generate invalid SQL was updated in Ruby on Rails
  • Adam Keys
    Adam Keys commented at 10:36 PM

    This is occurring under rails-3.0.0.beta3.
  • Adam Keys
    Adam Keys created the ticket at 10:34 PM

    If one creates a query that uses both limits and order clauses that contain punctuation, column aliases are put in the wrong place and an invalid query is gener...
Wednesday, September 03 2008
962 #injecting on Enumerable was updated in Ruby on Rails
  • Adam Keys
    Adam Keys commented at 3:16 PM

    Done.
  • Adam Keys
    Adam Keys created the ticket at 11:24 AM

    injecting makes inject easier to use. Rather than returning the accumulator from your block, the accumulator is modified in place.

    Apparently Merb had this meth...