Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Erik Ostrom

Erik Ostrom

Intermittent Engineer · Not a member

Erik Ostrom's latest activity

Monday, September 28 2009
3298 render :text with no layout fails when called from view or helper was created in Ruby on Rails
  • Erik Ostrom
    Erik Ostrom created the ticket at 7:00 PM

    In master:

    <%= render :text => 'Hello world!' %>

    produces no output. Likewise when you call render :text from a helper.

    This example is contrived, but it seem...
3260 ActionView::TestCase needs to be ported to master. was updated in Ruby on Rails
  • Erik Ostrom
    Erik Ostrom commented at 6:11 PM

    Yeah, that extension of helper_method is just what I had in mind.

    I was confused when I wrote about "tests to verify". I was referring to "is able to make metho...
  • Erik Ostrom
    Erik Ostrom commented at 7:54 AM

    I've attached a patch that makes all the tests pass. I haven't actually verified that you can use it in a real app. But I'm optimistic!

    I am somewhat skeptical ...
Sunday, September 27 2009
3260 ActionView::TestCase needs to be ported to master. was updated in Ruby on Rails
  • Erik Ostrom
    Erik Ostrom commented at 11:14 PM

    Much closer. I expect to have a working patch later today.
  • Erik Ostrom
    Erik Ostrom commented at 2:26 AM

    Never mind - it's over my head. Attached is a revision of Elad's patch that got me past the "tests don't run at all" phase and into the "dozens of test failures...
Saturday, September 26 2009
3260 ActionView::TestCase needs to be ported to master. was updated in Ruby on Rails
  • Erik Ostrom
    Erik Ostrom commented at 9:23 PM

    Patch doesn't apply cleanly to master. There are a couple of simple class renames in the way, and then a more complex refactoring. Several of the tests open Act...
3048 gem install fails when a gem requires multiple sources was updated in Ruby on Rails
  • Erik Ostrom
    Erik Ostrom commented at 5:19 AM

    +1 verified the behavior, the test, and the patch. Seems like this is a good workaround for a failing in RubyGems.
Monday, August 10 2009
3029 [PATCH] Non JavaScript dependent record deletion solution was updated in Ruby on Rails
2428 Unicode-aware rindex method was updated in Ruby on Rails
  • Erik Ostrom
    Erik Ostrom commented at 7:31 AM

    This patch no longer applies directly to master (or, the code no longer works, due to a change in the multibyte implementation). In the meantime someone filed a...
3028 ActiveSupport::Multibyte::Chars was updated in Ruby on Rails
  • Erik Ostrom
    Erik Ostrom commented at 7:19 AM

    I've attached a patch to be applied after my earlier one. The test is fixed so it passes on Ruby 1.9, and the implementation is fixed so it passes the fixed tes...