Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Ernie Miller's latest activity

Saturday, October 30 2010
5845 ActiveRecord 3 eager loading fail was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 4:30 PM

    Sure, I'll take a look at it right now.

Monday, October 25 2010
5845 ActiveRecord 3 eager loading fail was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 4:58 PM

    I'm checking the class of the variable being used in the right hand side of the comparison -- the left hand side is always a JoinAssociation, so I'm comparing t...

  • Ernie Miller
    Ernie Miller commented at 4:39 PM

    Ignore my foolishness above regarding the "unrelated bug" in habtm associations. I missed that the categories_posts fixture wasn't loaded in this test, which ex...

  • Ernie Miller
    Ernie Miller commented at 4:14 PM

    Speaking of which, I forgot to re-add those instantiation checks in my tests after working through some other issues. They're back in, now.

  • Ernie Miller
    Ernie Miller commented at 3:53 PM

    One other note - the associations you were using weren't producing any actual results, which is why you weren't seeing the bugs I mentioned... This is why it's ...

  • Ernie Miller
    Ernie Miller commented at 3:49 PM

    OK, I squashed all of the commits into one, and am attaching it here. Once again, switching Anatoliy's test against the post association (which always returns 0...

1 earlier change…
  • Ernie Miller
    Ernie Miller commented at 2:58 PM

    You're right. I forgot to port over a key part of the metawhere JoinDependency#build code. I'll correct it momentarily, and include details about the @associati...

Saturday, October 23 2010
5845 ActiveRecord 3 eager loading fail was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 9:24 PM

    Anatoliy,

    Yours takes care of the duplicate joins in the first place mentioned (I don't care for the refactor of the two-line build process into one line) but i...

  • Ernie Miller
    Ernie Miller commented at 8:22 PM

    Aaaaand attaching the patch. Yay.

  • Ernie Miller
    Ernie Miller commented at 8:21 PM

    Updated patch attached. This prevents the issue I described above by only allowing associations to be joined once. This is mostly an extract from a similar rout...