Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Ernie Miller

Ernie Miller

Not a member

Ernie Miller's latest activity

Saturday, October 23 2010
5845 ActiveRecord 3 eager loading fail was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 1:45 PM

    So, you say this code works on 2.3.x, but I don't see how identical code could have existed on 2.3.x since #includes is a 3.x method. Your problem, to me, appea...
Thursday, October 21 2010
5845 ActiveRecord 3 eager loading fail was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 3:59 AM

    Test improved and fix attached.
  • Ernie Miller
    Ernie Miller commented at 2:47 AM

    To be honest, I hadn't seen the patch with test, as I'd quickly
    skimmed the ticket on my iPhone after he sent me a mail asking me to
    take a look at it.

    I'll pul...
Wednesday, October 20 2010
5845 ActiveRecord 3 eager loading fail was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 1:46 PM

    The text of the ActiveRecord::ConfigurationError would be helpful. I'm assuming it says "Association named tags was not found?"

    Also, since you didn't name your...
Wednesday, July 28 2010
3165 ActiveRecord::MissingAttributeError after update to rails v 2.3.4 was updated in Ruby on Rails
  • Ernie Miller
    • Tag changed from 2.3.4, 2.3.5, activerecord, exception, patch to 2.3.4, 2.3.5, 3.0.0.rc, activerecord, exception, patch
    by Ernie Miller at 9:28 PM

    Yup, just ran into this in 3.0.0rc as well. Only happens when doing a query that includes associations with corresponding conditions, triggering the old join co...
Thursday, July 15 2010
5124 [PATCH] ActiveRecord count fails when run with multiple includes and a join was updated in Ruby on Rails
  • Ernie Miller
    Ernie Miller commented at 8:14 PM

    Good catch. As the guy who did the original refactor in associations.rb to add the graft method, I wanted to weigh in.

    def find_parent_in(other_join_dependency)

    ...
Wednesday, June 16 2010
4368 Patch: Access to more Arel predicate types from where condition hash was updated in Ruby on Rails
Tuesday, June 08 2010
4679 Multiple self-referencing eager loads don't join properly was updated in Ruby on Rails
  • Ernie Miller
    • Assigned user set to Pratik
    by Ernie Miller at 12:33 AM

    Pratik, sorry for sending this your way but I don't want to see Rails 3 release with this silly bug :)
Monday, May 24 2010
4679 Multiple self-referencing eager loads don't join properly was updated in Ruby on Rails
  • Ernie Miller
    • Tag changed from joindependency, rails3 to joindependency, patch, rails3, tests
    by Ernie Miller at 2:18 PM
  • Ernie Miller
    Ernie Miller created the ticket at 1:33 PM

    This is from #4463 -- decided it's probably better to create a new ticket than submit a fix to an already committed ticket. I made a small, silly error in the p...