Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Prem Sichanugrist (sikachu)'s latest activity

Wednesday, January 20 2010
3607 after_validate does not stop when false is returned was updated in Ruby on Rails
Prem Sichanugrist (sikachu) Prem Sichanugrist (sikachu) was invited to Ruby on Rails at 9:54 AM
3130 [PATCH] add strip_attributes support to ActiveModel and Active Record was updated in Ruby on Rails
  • Prem Sichanugrist (sikachu)
    Prem Sichanugrist (sikachu) commented at 9:23 AM

    @Josh Sharpe

    After I have discuss your addition in #rails-contrib, I can't really find a good use case for this method. So, I think this feature would be nice t...

  • Prem Sichanugrist (sikachu)
    • Tag changed from 3.0, activemodel, activerecord, bugmash, strip_attribtutes to 3.0, activemodel, activerecord, bugmash, bugmash-review, review, strip_attribtutes
    by Prem Sichanugrist (sikachu) at 6:43 AM
  • Prem Sichanugrist (sikachu)
    Prem Sichanugrist (sikachu) commented at 6:43 AM

    I've modify the patch to be applied on master

3745 Having rails/init.rb in plugin should generate deprecation warning since it's... was updated in Ruby on Rails
  • Prem Sichanugrist (sikachu)
    • Title changed from rails/init.rb is not being called anymore to Having rails/init.rb in plugin should generate deprecation warning since it's is not being called anymore
    by Prem Sichanugrist (sikachu) at 6:10 AM

    @Gabe da Silveira

    +1 on the deprecation warning. I believe that Rails 3 is under rapid development, so they forgot to put one in.

    @Ryan

    After I have followed th...

Tuesday, January 19 2010
3719 Errors in mutlibyte_chars_test for ActiveSupport was updated in Ruby on Rails
  • Prem Sichanugrist (sikachu)
    Prem Sichanugrist (sikachu) commented at 1:47 AM

    This is confirmed in Rails 1.9.1p376.

    Also, there're lots of 'warning: too many arguments for format string' message. Is there anything we can fix?

Monday, January 18 2010
3741 [PATCH] to_utc_offset_s misbehaviour if hour is < 0 was updated in Ruby on Rails
  • Prem Sichanugrist (sikachu)
    • Tag changed from 2-3-stable, 2.3.6, 2.3.x, active_support, core_ext, patch, review to 2-3-stable, 2.3.6, 2.3.x, active_support, bugmash, core_ext, patch, review
    • Title changed from [patch] to_utc_offset_s misbehaviour if hour is < 0 to [PATCH] to_utc_offset_s misbehaviour if hour is < 0
    by Prem Sichanugrist (sikachu) at 7:02 PM
  • Prem Sichanugrist (sikachu)
    • Tag changed from 2-3-stable, 2.3.6, 2.3.x, active_support, core_ext to 2-3-stable, 2.3.6, 2.3.x, active_support, core_ext, patch, review
    • Title changed from to_utc_offset_s misbehaviour if hour is < 0 to [patch] to_utc_offset_s misbehaviour if hour is < 0
    by Prem Sichanugrist (sikachu) at 6:59 PM

    Here are patches for 2-3-stable and master

  • Prem Sichanugrist (sikachu)
    Prem Sichanugrist (sikachu) commented at 6:35 PM

    Oh wait, ActiveSupport::TimeZone also has a bug.

    irb(main):027:0> ActiveSupport::TimeZone.seconds_to_utc_offset -3599
    => "-01:59"
    

    It should be "-00:59". Will ...