Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Diego Carrion

Diego Carrion

Not a member

Diego Carrion's latest activity

Saturday, March 05 2011
6529 Refactored and reduced method calls on Engine.find was created in Ruby on Rails
  • Diego Carrion
    Diego Carrion created the ticket at 5:06 AM

    Hi, Engine.path is expanding the same path passed as an argument every time it compares it with the engines paths. I changed the code to expand it only once and...
Friday, March 04 2011
6526 Revert deleted tests by past commit was created in Ruby on Rails
6515 Refactors on Date#<=> and DateTime#<=> was updated in Ruby on Rails
  • Diego Carrion
    Diego Carrion commented at 3:26 PM

    Ok, I executed 10000 times with Ruby 1.8.7 the tests, each with 3 asserts, that compares:

    Time with Time
    Time with DateTime
    Time with TimeWithZone
    DateTime with...
  • Diego Carrion
    Diego Carrion commented at 3:43 AM

    Yes, no problem, will come with the results :)
  • Diego Carrion
    Diego Carrion created the ticket at 12:02 AM

    Hi, I was analyzing an application trace and I came to Time#<=> and DateTime#<=>. I was doing some tests and ended up refactoring the two methods. I don't know ...
Monday, February 28 2011
6484 Ignore test/tmp folder created by ActiveSupport tests was updated in Ruby on Rails
  • Diego Carrion
    Diego Carrion commented at 2:44 AM

    Oh, sorry :P
  • Diego Carrion
    Diego Carrion created the ticket at 2:03 AM

    Hi, ActiveSupport's test Rake task is creating a test/tmp folder and this folder is not being ignored by Git, dirtying the repository. In the attached patch I a...
Saturday, February 19 2011
6455 Added Range#cover? was created in Ruby on Rails
  • Diego Carrion
    Diego Carrion created the ticket at 11:51 PM

    Hi, I added Range#cover? case it doesn't exist (Ruby 1.8). This modification allowed a considerable refactoring of ActiveModel::Validations::InclusionValidator#...
Saturday, September 25 2010
5655 [PATCH] rendering an object as json calls JSON.encode(object) instead of obje... was updated in Ruby on Rails
Saturday, September 18 2010
5654 [PATCH] Update session store documentation was updated in Ruby on Rails
  • Diego Carrion
    Diego Carrion commented at 4:47 PM

    I did update the documentation directly by the repo, thanks.