Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Brian Johnson

Brian Johnson

Not a member

Brian Johnson's latest activity

Tuesday, July 07 2009
2840 FormHelper's auto_index should create more "friendly" ids or revert back to i... was updated in Ruby on Rails
  • Brian Johnson
    Brian Johnson commented at 8:37 AM

    ok, I needed two lines to cover nested forms. I used method(method_name).call instead of send because the test was failing on the Structs in the tests, not sure...
Thursday, July 02 2009
2840 FormHelper's auto_index should create more "friendly" ids or revert back to i... was updated in Ruby on Rails
  • Brian Johnson
    Brian Johnson commented at 10:15 PM

    so I guess maybe there is no real issue with . or : in general, but it doesn't change the fact that it would be nice to have the option to use the id instead. I...
  • Brian Johnson
    Brian Johnson commented at 10:05 PM

    forget it, you can escape there too with .
  • Brian Johnson
    Brian Johnson commented at 10:00 PM

    I'll try that again

    <html>
<style>
  #test.dot {
    color: red;
  }
</style>
<body>
<div id="test.dot">test</div>
</body>
</html>
  • Brian Johnson
    Brian Johnson commented at 9:58 PM

    What about this?

    @@@html

    #test.dot {

    color: red;

    }

    test
  • Brian Johnson
    Brian Johnson commented at 7:44 PM

    if you think that would work, I can come up with a patch, but I don't want to spend time on something that isn't going to be used.
2 earlier changes…
  • Brian Johnson
    Brian Johnson commented at 7:37 PM

    another option would be an option :index => :id_before_type_cast where the symbol would be any method you want to run as the index parameter
  • Brian Johnson
    Brian Johnson commented at 7:32 PM

    what about at least removing . and : from the allowed characters? Technically they're legal, but they do cause issues. I started this ticket because I had a to_...
Friday, June 26 2009
2840 FormHelper's auto_index should create more "friendly" ids or revert back to i... was updated in Ruby on Rails
  • Brian Johnson
    Brian Johnson commented at 3:56 AM

    This ticket is a perfect example of why to_param seems like the wrong thing to do. Imagine an id that is ticket_2840-formhelpers-auto_index-should-create-more-f...
  • Brian Johnson
    Brian Johnson created the ticket at 3:54 AM

    sanitized_object_name allows . and : which are perfectly legal according to the specs, but still cause issues with jQuery in particular and I think some browser...