Brian Johnson

Graeme, your tests pass on my fork. Thomas, I'd like to include your issue as well, but I need a failing test first.

That's really strange because id_to_record_map, ids = construct_id_map(records, reflection.options[:primary_key]) is functionally equivalent to your patch. You ...

Ok, everything is good on edge rails with include, but I added a test case to the git repo anyway.

apparently my issue was related to http://rails.lighthouseapp.com/p...

just FYI - looks like this is already changed in edge, but the association isn't preloading for me. I'm working on a test case for it.

id_to_record_map, ids = c...

If you can make a test case for it I will add it to my git repo. Not sure what the best way to get this back into the main repo though, maybe I should do a pull...

Oops, my bad. Yes, this is for a bug with has_one. I guess I had has_one on my mind so I saw has_one instead of has_many in the title. There is a similar bug in...

Sorry, just one more thing, this started as ticket 1756 http://rails.lighthouseapp.com/p...

I also made an update to make one of the changes consistent with the existing fix from this ticket.

There is still an issue in has_one in associations.rb and new_record in has_one_association.rb. There are some tests included in the commit, but just from looki...