Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Victor Costan

Victor Costan

Software Developer · Not a member

Victor Costan's latest activity

Sunday, August 08 2010
5332 DEFAULT_*_OPTIONS cause inconsistencies in FormHelper was updated in Ruby on Rails
  • Victor Costan
    Victor Costan commented at 1:55 AM

    Added a patch that removes DEFAULT*OPTIONS in FormHelper. Will follow up with a patch that sets input field sizes in scaffold.css.
  • Victor Costan
    Victor Costan created the ticket at 12:33 AM

    For example, DEFAULT_FIELD_OPTIONS is {'size' => 30}, which causes text_field to emit a size="30" HTML attribute. The inconsistencies are
    in the RDoc; e.g., the...
Wednesday, June 30 2010
5018 lib/ files not autoloaded anymore was created in Ruby on Rails
  • Victor Costan
    Victor Costan created the ticket at 1:38 PM

    I used to be able to get files under lib/ loaded automatically, by referencing the name of the class / module defined in them. This is no longer true in Rails 3...
Friday, May 28 2010
1905 app/helpers within plugin not being mixed in was updated in Ruby on Rails
  • Victor Costan
    Victor Costan commented at 7:53 AM

    It's really sadist to have bugs like this lying around. I spent over an hour trying to figure out what's broken in my plugin, because I was getting my controlle...
Sunday, May 16 2010
4561 Factor out hardcoded style in form div wrapping hidden inputs was updated in Ruby on Rails
  • Victor Costan
    Victor Costan commented at 1:07 AM

    Updated patch.
  • Victor Costan
    • Assigned user set to Santiago Pastorino
    by Victor Costan at 12:36 AM

    I thought that Rails 3 is trying to move towards having a clean API for plugins.

    I'm sorry for "def test"... I did that patch at 5am... I have no other explanat...
Sunday, May 09 2010
4561 Factor out hardcoded style in form div wrapping hidden inputs was updated in Ruby on Rails
  • Victor Costan
    • Tag changed from actionview, rails3 to actionview, patch, rails3
    by Victor Costan at 9:47 AM
  • Victor Costan
    Victor Costan commented at 9:34 AM

    Patch containing code and tests. Applies cleanly against Rails 3 edge. The method name (hidden_field_wrapper_tag) might not be the best option, I can change it ...
  • Victor Costan
    Victor Costan created the ticket at 9:25 AM

    In most circumstances, form_tag generates a

    with style="margin:0;padding:0;display:inline". Using the style attribute isn't great, because the style cannot be o...
4486 New UJS helpers do not have a way to render a "loading..." text / icon was updated in Ruby on Rails
  • Victor Costan
    Victor Costan commented at 6:11 AM

    How about allowing :remote to take a Hash of options instead of true? The option :indicator (rendered as a data-indicator-name attribute) would be a name that w...