#4561 Factor out hardcoded style in form div wrapping hidden inputs - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4561 ✓wontfix

Factor out hardcoded style in form div wrapping hidden inputs

Reported by Victor Costan | May 9th, 2010 @ 09:25 AM

In most circumstances, form_tag generates a

with style="margin:0;padding:0;display:inline". Using the style attribute isn't great, because the style cannot be overridden from CSS. This is a real problem for me, it's preventing me from using the CSS 3 flexible box support in Firefox.

The solution I propose is as follows: factor out the

generation into a public method in FormTagHelper, and call that method from form_tag. This way, a plugin can safely override that method to render something like

. This approach does not break existing applications.

Comments and changes to this ticket

You flagged this item as spam.
Victor Costan May 9th, 2010 @ 09:34 AM
Patch containing code and tests. Applies cleanly against Rails 3 edge. The method name (hidden_field_wrapper_tag) might not be the best option, I can change it to whatever people think would work.
You flagged this item as spam.
Victor Costan May 9th, 2010 @ 09:47 AM
- Tag changed from “actionview, rails3” to “actionview, patch, rails3”
Dan Pickett May 9th, 2010 @ 05:50 PM
- Tag changed from “actionview, patch, rails3” to “actionview, bugmash, patch, rails3”
Jeff Kreeftmeijer May 15th, 2010 @ 02:54 PM
+1

Applies to master cleanly and tests pass. Looks a lot cleaner. :)
You flagged this item as spam.
Anil Wadghule May 15th, 2010 @ 03:38 PM
+1 Looks fine.
You flagged this item as spam.
PacoGuzman May 15th, 2010 @ 04:14 PM
+1 All test pass, looks fine
You flagged this item as spam.
Casey Dreier May 15th, 2010 @ 05:18 PM
+1 No problems applying patch. All tests pass.
You flagged this item as spam.
Wijnand Wiersma May 15th, 2010 @ 06:55 PM
+1 Works fine.
Santiago Pastorino May 15th, 2010 @ 10:38 PM
I know that naming are one of the most difficult things in programming but def test doesn't seem to be right :), make an effort, don't be lazy like me :P
Santiago Pastorino May 16th, 2010 @ 12:08 AM
- State changed from “new” to “wontfix”
Sorry this is not going to be fixed, don't worth changing the API for this, you can MonkeyPatch, thanks.
You flagged this item as spam.
Victor Costan May 16th, 2010 @ 12:36 AM
- Assigned user set to “Santiago Pastorino”
I thought that Rails 3 is trying to move towards having a clean API for plugins.

I'm sorry for "def test"... I did that patch at 5am... I have no other explanation for how that got in there! I totally meant test_hidden_field_wrapper_tag!

Can you please reconsider if I send in an updated patch?
You flagged this item as spam.
Victor Costan May 16th, 2010 @ 01:07 AM
Updated patch.
- factor-out-magic-div.diff 2.9 KB