Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Wijnand Wiersma

Wijnand Wiersma

Not a member

Wijnand Wiersma's latest activity

Thursday, July 08 2010
5017 accepts_nested_attributes_for problems with inheritance was updated in Ruby on Rails
  • Wijnand Wiersma
    Wijnand Wiersma commented at 9:32 PM

    To follow up on this:
    If you only add accepts_nested_attributes to the child model it won't work properly either.
    At the time the check for autosave is performe...
Wednesday, June 30 2010
5017 accepts_nested_attributes_for problems with inheritance was created in Ruby on Rails
Tuesday, June 29 2010
4183 Possible memory leak in Rails 3 was updated in Ruby on Rails
  • Wijnand Wiersma
    Wijnand Wiersma commented at 12:14 PM

    I can confirm this. It seems to grow about 20Mb per request when running bundle exec rails s.
    Ruby version:
    ruby 1.8.7 (2009-06-08 patchlevel 173) [universal-da...
Sunday, May 16 2010
1244 caches_page does not respect Accept header was updated in Ruby on Rails
  • Wijnand Wiersma
    Wijnand Wiersma commented at 10:28 PM

    After discussing with José Valim we decided it would be better to set ActionController::Base.page_cache_extension to nil by default and always use request.forma...
  • Wijnand Wiersma
    Wijnand Wiersma commented at 7:54 PM

    Well, in normal requests you want to respect any ActionController::Base.page_cache_extension configuration a user might have done. The issue here was special re...
  • Wijnand Wiersma
    • Tag changed from bugmash, cache, caches_page, caching, format, patch, respond_to to bugmash, bugmash-review, cache, caches_page, caching, format, patch, respond_to
    by Wijnand Wiersma at 4:54 PM

    I attached updated patches. No more messing around with page_cache_extension. Just add the correct extension to the path when no extension is known.
  • Wijnand Wiersma
    Wijnand Wiersma commented at 3:54 PM

    I agree changing the value is not very clean. I am currently writing a very different patch.
3664 CookieStore does not implement backwards compatibility for :session_domain was updated in Ruby on Rails
4617 [PATCH] Added nokogiri dependency to Gemfile was updated in Ruby on Rails
  • Wijnand Wiersma
    Wijnand Wiersma commented at 7:22 PM

    +1 And it does not fail on jruby for me.
2992 [PATCH] visibility of fixture accssor methods was updated in Ruby on Rails
  • Wijnand Wiersma
    Wijnand Wiersma commented at 3:21 PM

    I attached patches that apply to master and 2-3-stable.