Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

CookieStore does not implement backwards compatibility for :session_domain

#3664

In cookie_store.rb (2.3.5), there is support for backwards compatibility of several keys:

    # Process legacy CGI options
    options = options.symbolize_keys
    if options.has_key?(:session_path)
      options[:path] = options.delete(:session_path)
    end
    if options.has_key?(:session_key)
      options[:key] = options.delete(:session_key)
    end
    if options.has_key?(:session_http_only)
      options[:httponly] = options.delete(:session_http_only)
    end

But there is no support for :session_domain. Should this be added for completeness sake?

    if options.has_key?(:session_domain)
      options[:domain] = options.delete(:session_domain)
    end

Reported by Andrew Selder · January 6th, 2010 @ 06:54 PM

State: stale
Milestone: 2.3.10
Assigned to: nobody
Importance: none

Activity

  1. Jeremy Kemper
    Jeremy Kemper
    • State changed from new to open
    • Assigned user set to josh
    • Milestone set to 2.3.6

    January 6th, 2010 @ 11:20 PM

  2. josh
    josh
    • Assigned user cleared.

    Looks fine, can you write a patch along w/ some tests please.

    January 10th, 2010 @ 03:01 PM

  3. Rizwan Reza
    Rizwan Reza
    • Tag changed from cookie_store, sessions to bugmash, cookie_store, sessions

    May 16th, 2010 @ 02:41 AM

  4. ronin-16776 (at lighthouseapp)
    ronin-16776 (at lighthouseapp)

    This patch for 2-3-stable add backwards compatibility for :session_domain in cookie_store.rb

    May 16th, 2010 @ 04:57 PM

  5. Josh Kalderimis
    Josh Kalderimis

    +1

    patch and test apply fine

    May 16th, 2010 @ 06:57 PM

  6. Wijnand Wiersma
    Wijnand Wiersma

    +1 patch works fine, test passes

    May 16th, 2010 @ 07:44 PM

  7. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.3.6 to 2.3.7

    May 23rd, 2010 @ 05:54 PM

  8. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.3.7 to 2.3.8

    May 24th, 2010 @ 09:40 AM

  9. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.3.8 to 2.3.9

    May 25th, 2010 @ 11:45 PM

  10. Jeremy Kemper
    Jeremy Kemper
    • Milestone changed from 2.3.9 to 2.3.10

    August 30th, 2010 @ 02:28 AM

  11. rails
    rails

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

    May 2nd, 2011 @ 01:00 AM

  12. rails
    rails
    • State changed from open to stale

    May 2nd, 2011 @ 01:00 AM