This project is archived and is in readonly mode.
CookieStore does not implement backwards compatibility for :session_domain
Reported by Andrew Selder | January 6th, 2010 @ 06:54 PM | in 2.3.10
In cookie_store.rb (2.3.5), there is support for backwards compatibility of several keys:
# Process legacy CGI options
options = options.symbolize_keys
if options.has_key?(:session_path)
options[:path] = options.delete(:session_path)
end
if options.has_key?(:session_key)
options[:key] = options.delete(:session_key)
end
if options.has_key?(:session_http_only)
options[:httponly] = options.delete(:session_http_only)
end
But there is no support for :session_domain. Should this be added for completeness sake?
if options.has_key?(:session_domain)
options[:domain] = options.delete(:session_domain)
end
Comments and changes to this ticket
-
Jeremy Kemper January 6th, 2010 @ 11:20 PM
- State changed from new to open
- Assigned user set to josh
- Milestone set to 2.3.6
-
josh January 10th, 2010 @ 03:01 PM
- Assigned user cleared.
Looks fine, can you write a patch along w/ some tests please.
-
Rizwan Reza May 16th, 2010 @ 02:41 AM
- Tag changed from cookie_store, sessions to bugmash, cookie_store, sessions
-
ronin-16776 (at lighthouseapp) May 16th, 2010 @ 04:57 PM
This patch for 2-3-stable add backwards compatibility for :session_domain in cookie_store.rb
-
rails May 2nd, 2011 @ 01:00 AM
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
rails May 2nd, 2011 @ 01:00 AM
- State changed from open to stale
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>