This project is archived and is in readonly mode.

#3664 ✓stale
Andrew Selder

CookieStore does not implement backwards compatibility for :session_domain

Reported by Andrew Selder | January 6th, 2010 @ 06:54 PM | in 2.3.10

In cookie_store.rb (2.3.5), there is support for backwards compatibility of several keys:

    # Process legacy CGI options
    options = options.symbolize_keys
    if options.has_key?(:session_path)
      options[:path] = options.delete(:session_path)
    end
    if options.has_key?(:session_key)
      options[:key] = options.delete(:session_key)
    end
    if options.has_key?(:session_http_only)
      options[:httponly] = options.delete(:session_http_only)
    end

But there is no support for :session_domain. Should this be added for completeness sake?

    if options.has_key?(:session_domain)
      options[:domain] = options.delete(:session_domain)
    end

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Pages