Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Jakub Suder's latest activity

Friday, October 08 2010
5274 better error messages when incorrect regexp is passed to constraints in routes was updated in Ruby on Rails
  • Jakub Suder
    Jakub Suder commented at 9:23 AM

    That should be enough, thanks.

Thursday, October 07 2010
5274 better error messages when incorrect regexp is passed to constraints in routes was updated in Ruby on Rails
  • Jakub Suder
    Jakub Suder commented at 7:51 PM

    Well, the guide you linked to shows examples with regexps without start/end markers...

    Example from that link:

    constraints(:id => /[A-Z][A-Z][0-9]+/) do
    

    And i...

Tuesday, September 07 2010
5374 as_json should return a hash for ActiveModel/ActiveRecord objects was updated in Ruby on Rails
Friday, September 03 2010
5545 capture helper assumes that text is html_safe was created in Ruby on Rails
  • Jakub Suder
    Jakub Suder created the ticket at 12:04 PM

    That may cause XSS issues if you don't expect it...

    Example:

    <p><%= @profile.location %></p>
    <p><%= capture { @profile.location } %></p>
    <p><%= content_tag(:di...
Sunday, August 29 2010
5374 as_json should return a hash for ActiveModel/ActiveRecord objects was updated in Ruby on Rails
  • Jakub Suder
    Jakub Suder commented at 8:05 PM

    I'm updating the ticket with a new, extended version of the patch. This got much more complicated than I thought at first, every time I fixed something I kept f...

Wednesday, August 25 2010
5231 print stack traces with deprecation warnings was updated in Ruby on Rails
  • Jakub Suder
    Jakub Suder commented at 8:20 AM

    Good point, I've updated the patch.

Tuesday, August 24 2010
5231 print stack traces with deprecation warnings was updated in Ruby on Rails
  • Jakub Suder
    Jakub Suder commented at 10:37 PM

    That's what the Rails cleaner would do, because it's configured by default to filter out everything that doesn't match APP_DIRS_PATTERN = /^\/?(app|config|lib|t...

  • Jakub Suder
    Jakub Suder commented at 10:25 PM

    I think an option is not necessary here, you don't really need the whole stack trace, as I thought initially - all it would tell you in the example above is how...

  • Jakub Suder
    Jakub Suder commented at 10:22 PM

    At this point of time I am seeing a lot of deprecation messages from third party gems. If the offending line is not there then the deprecation message might be...

  • Jakub Suder
    Jakub Suder commented at 10:01 PM

    Honestly, I don't think this makes much sense in this case... The code in ActionDispatch uses the cleaner (if available) to remove some useless lines from the t...