Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Martin Andert's latest activity

Wednesday, April 14 2010
2523 Add 'field' attribute to ActiveRecord::Errors#to_xml was updated in Ruby on Rails
  • Martin Andert
    Martin Andert commented at 7:54 PM

    See also Ticket #1625.

    Instead of

    <error field="...">...</error>
    

    I would prefer

    <error on="...">...</error>
    

    like in error_messages_on.

1625 Allow active record errors to_xml to return separate tags for attribute and m... was updated in Ruby on Rails
  • Martin Andert
    Martin Andert commented at 7:44 PM

    I would prefer it this way:

    <errors>
      <error on="title">Title can't be blank</error>
      <error on="username">Username is already taken</error>
    </errors>
    

    So on...

Wednesday, February 17 2010
3629 weird behavior on error_messages_for was updated in Ruby on Rails
  • Martin Andert
    Martin Andert commented at 1:57 PM

    And here is the test case and the fix in one patch.

  • Martin Andert
    • Tag changed from 2.3.5, error_messages_for, i18n to 18, 2, error_messages_for
    by Martin Andert at 1:56 PM

    I have attached a failing test case.

Tuesday, February 16 2010
3629 weird behavior on error_messages_for was updated in Ruby on Rails
  • Martin Andert
    • Tag changed from 2.3.5 to 2.3.5, error_messages_for, i18n
    by Martin Andert at 1:02 PM
  • Martin Andert
    Martin Andert commented at 1:00 PM

    I am experiencing the same problem. Looks as error_messages_for does a gsub('_', ' ') on the object name before handing it to i18n. My current workaround:

    de:
    ...
Friday, January 15 2010
2785 [PATCH] scoped translation throws an exception was updated in Ruby on Rails
  • Martin Andert
    • Tag changed from i18n, rails3 to bugmash, i18n, rails3
    by Martin Andert at 12:41 PM
Monday, September 07 2009
2785 [PATCH] scoped translation throws an exception was updated in Ruby on Rails
  • Martin Andert
    Martin Andert commented at 8:45 AM

    The patch for rails3 doesn't apply (anymore). The template Variable seems to be always nil. As a fix for this I changed a line in action_view/render/rendering.r...

Monday, March 16 2009
2251 AssociationCollection#destroy should only delete join table records was updated in Ruby on Rails
  • Martin Andert
    Martin Andert commented at 12:45 PM

    Oh, that last "<<" should not be there in my test (copy & paste error). Now the test passes. Thank you.

  • Martin Andert
    Martin Andert commented at 11:47 AM

    Oh, the second code snippet must be

    
    def destroy(*records)
      super
      delete_records(flatten_deeper(records))
    end
    

    Sorry.