Si
Not a member
Si's latest activity
Friday, May 07 2010
-
Si commented at 8:24 AMHi Kevmoo, I updated that patch but the fix is the same in Neeraj's diff. Can you try that?
Saturday, May 01 2010
-
Si commented at 8:36 AMNow I'm pushing up to staging I see that the before filter will need to return true in all cases. This is because the sweeper filter aspect is really implementa...
Thursday, April 29 2010
Wednesday, April 28 2010
Tuesday, April 27 2010
-
Si commented at 4:27 PMHi Simon, I just tried the patch and get the same error:
PhusionPassenger::Utils::RewindableInput is not a valid input stream. It must walk like either a Stri...
-
Si commented at 3:20 PMHi James,
I'm not a fan of the style employed by AcceptanceValidationTest. The tests are named according to attribute tested (e.g. test_eula), instead of explic...
-
Si commented at 10:58 AMSure!
I wasn't set up for tests in the activemodel area before, primarily due to a MySQL dependency. Here's a patch to use database backing for the terms_of_ser...
Thursday, April 22 2010
-
Si created the ticket at 10:27 PMIn AcceptanceValidator#setup (/lib/active_model/validations/acceptance.rb), the class instance methods are inspected, to see if a writer method exists for each ...
Sunday, April 04 2010
-
- Tag changed from cache, cache_sweeper, sweeper to cache, cache_sweeper, patch, sweeper