Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Jesse Storimer's latest activity

Tuesday, August 24 2010
5348 Visibility of helpers seems all wrong was updated in Ruby on Rails
  • Jesse Storimer
    Jesse Storimer commented at 7:47 PM

    Would you consider accepting something along the lines of https://rails.lighthouseapp.com/projects/8994/tickets/4750 ?

  • Jesse Storimer
    Jesse Storimer commented at 7:20 PM

    I think Matt Schafer put it best:

    Mixing in all helpers into every renderer pretty much defeats the purpose of having per-controller helpers. With the current ...

  • Jesse Storimer
    Jesse Storimer commented at 7:07 PM

    José,

    I'd rather not have Rails call helper :all for all my controllers. That doesn't seem like a decision that the framework should make for me. AFAIK this was...

  • Jesse Storimer
    Jesse Storimer commented at 1:54 PM

    I tried removing the call to helper :all in ActionController::Base and all the tests are still passing, plus I think the code is clearer without that line.

    Here...

Thursday, August 19 2010
5348 Visibility of helpers seems all wrong was updated in Ruby on Rails
  • Jesse Storimer
    • Tag changed from rails 3.0.rc, actionpack, verified to rails 3.0.rc, actionpack, patch, verified
    by Jesse Storimer at 3:27 AM

    I was able to find the issue and add a regression test.

    In 37e4deb2 there was a change such that any subclass of ActionController::Base would automatically get ...

Wednesday, August 18 2010
5348 Visibility of helpers seems all wrong was updated in Ruby on Rails
  • Jesse Storimer
    Jesse Storimer commented at 2:14 PM

    From the example I posted above this might seem like a 'quirk', but the real problem arises when there is a situation like this:

    module ProductsHelper
      def ti...
Tuesday, August 10 2010
5348 Visibility of helpers seems all wrong was updated in Ruby on Rails
  • Jesse Storimer
    Jesse Storimer commented at 6:46 PM

    Ouch. Formatting fail.

    Here's a gist formatted properly: http://gist.github.com/517669

  • Jesse Storimer
    Jesse Storimer created the ticket at 6:44 PM

    In upgrading an app to Rails 3 and noticed that the visibility of helpers seemed to be messed up. The gist below demonstrates how to reproduce the issue.

    http:/...

Wednesday, June 02 2010
4743 Session Cookie breaks if used with custom cookie in rails 2.3.8 was updated in Ruby on Rails
  • Jesse Storimer
    Jesse Storimer commented at 3:14 PM

    So my patch solved the issue but it produced some weird behaviour. ActionController::Response#convert_cookies! converts the Set-Cookie header to an array if the...

Tuesday, June 01 2010
4743 Session Cookie breaks if used with custom cookie in rails 2.3.8 was updated in Ruby on Rails
  • Jesse Storimer
    • Tag changed from rails 2.3.8, bug, cookie_store, session to rails 2.3.8, bug, cookie_store, patch, session
    by Jesse Storimer at 1:42 PM