Jesse Storimer
Not a member
Jesse Storimer's latest activity
Thursday, January 13 2011
Tuesday, August 31 2010
-
Jesse Storimer created the ticket at 3:24 PMI can't find any mention of Module.safe_helper in Rails 3. I upgraded my 2.3.8 app to use rails_xss and used
safe_helperall over my helper modules. However, on...
Saturday, August 28 2010
-
Jesse Storimer commented at 3:52 PMHey José,
Thanks for the suggestion. Calling #ancestors directly felt pretty sketchy :P
Here's a new patch using class_attribute :_helper_methods. I tried this ...
Friday, August 27 2010
-
Jesse Storimer commented at 2:46 PMSo I spoke too soon :P The patch I offered does cover the case above.
Though I still have a feeling that this may come back to be a problem in the future. Disca...
-
Jesse Storimer commented at 12:17 PMBah, I think my solution above was too naive. It didn't take into account that libraries might be mixing helper_methods into ActionController::Base. Using clear...
-
Jesse Storimer commented at 3:34 AMI found another issue with this implementation. Some of the modules that get included in ActionController::Base define helpers using the
helper_methoddirective...
Thursday, August 26 2010
-
Jesse Storimer commented at 8:42 PMIf my example below wasn't the intended use case for that patch then you can safely ignore the rest of this :)
I'm not sure if this was the intended use case, b...
-
Jesse Storimer commented at 4:13 AMAs discussed offline the approach proposed turned out to be non-trivial and affected performance negatively. Attached is patch that takes a slightly different a...
-
Jesse Storimer created the ticket at 3:38 PMThis discussion started on #5348 but that ticket has diverged into a separate issue.
The issue here is that
helper :alldoesn't respect the current controller/v...