Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Martijn Vos's latest activity

Sunday, February 01 2009
1824 date_select may call TimelinessDateTime.change which doesn't exist was updated in Ruby on Rails
  • Martijn Vos
    Martijn Vos commented at 11:57 AM

    I understand. I'll submit a patch there.

Friday, January 30 2009
1824 date_select may call TimelinessDateTime.change which doesn't exist was updated in Ruby on Rails
  • Martijn Vos
    Martijn Vos commented at 4:44 PM

    Even so, isn't it dangerous for Rails to blindly assume that it receives a class of a specific type when that clearly isn't automatically true? A respond_to? ch...

  • Martijn Vos
    Martijn Vos commented at 12:21 AM

    This fix can also be found in http://github.com/mcv/rails/comm...

  • Martijn Vos
    • Tag set to select_date
    by Martijn Vos at 12:17 AM

    Here's the patch.

Thursday, January 29 2009
1824 date_select may call TimelinessDateTime.change which doesn't exist was created in Ruby on Rails
  • Martijn Vos
    Martijn Vos created the ticket at 11:56 PM

    For some reason, I don't quite understand why, does

    <%= f.date_select :card_expires_on, :discard_day => true, :start_year => Date.today.year, :end_year => (Dat...
Friday, January 09 2009
561 Date select helpers should have a :prompt option was updated in Ruby on Rails
  • Martijn Vos
    Martijn Vos commented at 8:54 AM

    Another minor but ugly issue that remains is that when I use the "year" select box, it starts at dates in the distant past. I want those to be available, but th...

1715 AR:Base mangles dates when user submits only part of the fields was updated in Ruby on Rails
  • Martijn Vos
    Martijn Vos commented at 7:38 AM

    This patch fixes the problem. For me at least -- it's likely there are use cases I'm not aware of.

    The patch doesn't add or update any tests because I couldn't ...

  • Martijn Vos
    Martijn Vos created the ticket at 7:05 AM

    When using date_select, it's possible for the user to submit only month and day, leaving year empty. How to handle that issue is up to the developer of the site...

Wednesday, December 24 2008
561 Date select helpers should have a :prompt option was updated in Ruby on Rails
  • Martijn Vos
    Martijn Vos commented at 12:38 PM

    add_prompts_to_date_helpers_2.3.0.diff doesn't entirely fix this issue when applied to 2.2.2. It still uses today as default value instead of nil.

    In date_helpe...

Tuesday, December 16 2008
561 Date select helpers should have a :prompt option was updated in Ruby on Rails
  • Martijn Vos
    Martijn Vos commented at 11:10 AM

    +1

    Why exactly is this stale, and not already in Rails?

    Also +1 on doing something similar for class name, although I think that should be a separate ticket.