Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Roman Shterenzon

Roman Shterenzon

Not a member

Roman Shterenzon's latest activity

Tuesday, February 03 2009
1633 has_many with :primary_key option bug was updated in Ruby on Rails
  • Roman Shterenzon
    Roman Shterenzon commented at 10:17 PM

    So, if I get it right, it has nothing to do with 'has_many' association? If this is indeed the case, then this bug can be closed.
Monday, February 02 2009
1633 has_many with :primary_key option bug was updated in Ruby on Rails
  • Roman Shterenzon
    Roman Shterenzon commented at 9:36 PM

    Brian, I've seen your commit, but I didn't quite understand what is missing in the current fix. Can you elaborate? Or, perhaps, define a failing test.
1693 [PATCH] Support for options[:expires_in] for ActiveSupport::Cache::FileStore was updated in Ruby on Rails
  • Roman Shterenzon
    • Assigned user set to josh
    by Roman Shterenzon at 6:24 PM

    Please note, that my changed code (due to avoidance of rescue clause using the File.exist?) is about order of magnitude faster (~8) for non-existent files than ...
Thursday, January 29 2009
1693 [PATCH] Support for options[:expires_in] for ActiveSupport::Cache::FileStore was updated in Ruby on Rails
  • Roman Shterenzon
    Roman Shterenzon commented at 9:46 AM

    According to my benchmark on my VMWare Linux it added 7 microseconds to every read from cache. IMHO it's tolerable.
Tuesday, January 27 2009
1693 [PATCH] Support for options[:expires_in] for ActiveSupport::Cache::FileStore was updated in Ruby on Rails
  • Roman Shterenzon
    • Tag changed from 2.2-stable, cache, patch to 2.2-stable, active_support, cache, patch
    • Assigned user set to josh
    by Roman Shterenzon at 6:48 PM

    Please review and tell me if there are any problems with this patch. Thanks!
Sunday, January 04 2009
1693 [PATCH] Support for options[:expires_in] for ActiveSupport::Cache::FileStore was created in Ruby on Rails
  • Roman Shterenzon
    Roman Shterenzon created the ticket at 6:09 PM

    While this options is supported for the MemCache Store, this support is missing in FileStore. Fortunately it's quite simple to implement. I also modified the do...
1633 has_many with :primary_key option bug was updated in Ruby on Rails
  • Roman Shterenzon
    Roman Shterenzon commented at 3:42 PM

    Is it possible to merge this to 2-2-stable branch?
Thursday, December 25 2008
1633 has_many with :primary_key option bug was updated in Ruby on Rails
  • Roman Shterenzon
    Roman Shterenzon commented at 9:59 PM

    Perhaps I fixed it in the wrong place, but it surely fixes the bug that I found while working on my application. Since the "primary_key" option is a part of the...
  • Roman Shterenzon
    Roman Shterenzon created the ticket at 7:15 PM

    Creating new object through a has_many association which has a :primary_key option doesn't work as expected, as it always assigns the id of the owner instead of...
1515 NoMethodError in AssociationProxy#method_missing isn't helpful was updated in Ruby on Rails
  • Roman Shterenzon
    Roman Shterenzon commented at 8:55 PM

    Perhaps it's better just to call the superclass?

    
@@ -206,7 +209,7 @@ module ActiveRecord
         # Forwards any missing method call to the \target.
      ...