Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

josh's latest activity

Monday, September 08 2008
948 template lookup should search controller inheritance chain was updated in Ruby on Rails
  • josh
    • State changed from open to wontfix
    by josh at 11:26 PM

    Temporary closing the ticket. Can you please email me (directly) when you come up with a kick ass solution. Thanks for looking into this.

  • josh
    • Milestone set to 2.x
    by josh at 11:25 PM

    :) I totally agree. If you could refactor some of that finder code i'd be more convinced to let it into core. I'm just a bit worried about adding the logic to d...

  • josh
    josh commented at 3:46 PM

    I'm starting to think this would be better off as a plugin. However, it is sucky that you have to override the pick partial stuff. We should fix this so your pl...

  • josh
    josh commented at 3:23 PM

    I shouldn't have to touch ActionView, since it only affects the controller's default template. Maybe it's missing a hook?

285 alias_method_chain limits extensibility was updated in Ruby on Rails
  • josh
    josh commented at 3:49 PM

    Is swapping out ActionController benchmark your real goal, or was it just an example? If it is, I'd like to see how we can do this w/o alias_method_chain.

Sunday, September 07 2008
285 alias_method_chain limits extensibility was updated in Ruby on Rails
  • josh
    josh commented at 11:14 PM

    The use case seems reasonable. I wonder if aliasing it back works?

    
    alias_method :perform_action, :perform_action_without_benchmark
    

    I also think those (Actio...

  • josh
    • Assigned user changed from josh to DHH
    by josh at 4:12 PM

    -1 I don't like the idea of replacing the alias with a delegate method call.

    @David I think that only cleans up the "target_method_exists = (instance_methods + ...

948 template lookup should search controller inheritance chain was updated in Ruby on Rails
  • josh
    • Milestone cleared.
    • State changed from new to open
    by josh at 3:59 PM

    You can you use git-format-patch to make me a diff file, please.

    I'm also curious how this applies to partial rendering. I ran into this problem a few times.

    ...
Friday, August 29 2008
935 Adding Regexp support for :only and :except options on filter_chains was updated in Ruby on Rails
  • josh
    • State changed from new to wontfix
    by josh at 8:47 PM

    Nice looking patch. However, you can already do this.

    
    class MyController < ActionController::Base
      before_filter :auth, :if => Proc.new { |controller|
         ...
908 Layout MIME type should match the response's was updated in Ruby on Rails
  • josh
    • State changed from new to open
    • Tag changed from 2.1, actionpack, bug, controller, edge, patch, tested, tests to actionpack
    by josh at 5:01 PM

    +1 if you can get it working.

    NOTE: test_layout_mime_should_match_responses should be broken up into separate cases