josh
Programmer · Account member
josh's latest activity
Monday, September 08 2008
-
- State changed from open to wontfix
Temporary closing the ticket. Can you please email me (directly) when you come up with a kick ass solution. Thanks for looking into this.
-
- Milestone set to 2.x
:) I totally agree. If you could refactor some of that finder code i'd be more convinced to let it into core. I'm just a bit worried about adding the logic to d...
-
josh commented at 3:46 PMI'm starting to think this would be better off as a plugin. However, it is sucky that you have to override the pick partial stuff. We should fix this so your pl...
-
josh commented at 3:23 PMI shouldn't have to touch ActionView, since it only affects the controller's default template. Maybe it's missing a hook?
-
josh commented at 3:49 PMIs swapping out ActionController benchmark your real goal, or was it just an example? If it is, I'd like to see how we can do this w/o alias_method_chain.
Sunday, September 07 2008
-
josh commented at 11:14 PMThe use case seems reasonable. I wonder if aliasing it back works?
alias_method :perform_action, :perform_action_without_benchmarkI also think those (Actio...
-
- Assigned user changed from josh to DHH
-1 I don't like the idea of replacing the alias with a delegate method call.
@David I think that only cleans up the "target_method_exists = (instance_methods + ...
-
- Milestone cleared.
- State changed from new to open
You can you use git-format-patch to make me a diff file, please.
I'm also curious how this applies to partial rendering. I ran into this problem a few times.
...
Friday, August 29 2008
-
- State changed from new to wontfix
Nice looking patch. However, you can already do this.
class MyController < ActionController::Base before_filter :auth, :if => Proc.new { |controller| ...
-
- State changed from new to open
- Tag changed from 2.1, actionpack, bug, controller, edge, patch, tested, tests to actionpack
+1 if you can get it working.
NOTE: test_layout_mime_should_match_responses should be broken up into separate cases