Dmitry Ratnikov

Here's a piece of code similar to what originally caused the issue:

@posts = Post.offset(10).limit(10)

<% unless @posts.empty? -%>

<% @posts.each do |post| -%>...

To be honest, I was leaning towards something like to underline the differences between new_record and not:

def include?(record)
         return false unless ...

Patches passes tests for mysql and sqlite3 adapters for 2-3-stable branch.

Looks good to me :)

I will apply that to 2.3 stable to check that it works.
I'll also check that it works if the has_many has finder_sql defined.

Consider:

class Post < ActiveRecord::Base
  has_many :comments
end

class Comment < ActiveRecord::Base
  belongs_to :post
end

The following test fails:

def ...

+1

Rebased my patch against master.

Here's an updated patch.

I made the tests actually fail rather than blow up.
Also, I had to resort to removing constants possibly defined by requiring models/co...

For some reason I fail to update the ticket with the attacked patch, so I put it on drop.io for now: http://drop.io/urxdaxz If someone has better luck attaching...