Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Lake

Lake

Not a member

Lake's latest activity

Monday, December 06 2010
6093 [PATCH] Uncountable singularize uses regex match while pluralize uses exact m... was updated in Ruby on Rails
  • Lake
    Lake commented at 3:01 AM

    +1 Tests are passing on master.

    Nicely done, JP.
Saturday, September 18 2010
5645 Rails 3.0.0 add_index fails silently on invalid index names was updated in Ruby on Rails
  • Lake
    Lake commented at 1:51 AM

    Great! With your patches combined, the tests pass.

    +1
Friday, September 17 2010
5641 Move capture to Kernel was updated in Ruby on Rails
  • Lake
    • Title changed from [PATCH] Move capture to Kernel to Move capture to Kernel
    by Lake at 5:35 AM
  • Lake
    Lake commented at 5:13 AM

    +1 for staying DRY. The tests pass for me and of course the code looks better.
5645 Rails 3.0.0 add_index fails silently on invalid index names was updated in Ruby on Rails
  • Lake
    Lake commented at 4:48 AM

    Thanks for you contribution.

    Unfortunately, your patch actually breaks a couple of tests. I recommend that you check out those tests and try to resolve them.

     ...
4554 render :text => proc { ... } regression was updated in Ruby on Rails
  • Lake
    Lake commented at 4:10 AM

    Your patch applies cleanly to master and the tests are passing.

    +1
Thursday, September 16 2010
5123 stylesheet_link_tag media default was updated in Ruby on Rails
  • Lake
    • Tag set to invalid
    by Lake at 11:14 PM
  • Lake
    Lake commented at 11:11 PM

    I agree with Marjan. You can pass the "media" option to set it to print.
5562 Build model from association with conditions was updated in Ruby on Rails
  • Lake
    • Tag changed from associations, patch, scope to associations, patch, scope, verified
    by Lake at 10:58 PM
4649 current_page? fails on namespaced controller with same base name was updated in Ruby on Rails
  • Lake
    Lake commented at 9:17 PM

    Hey Curtis,

    Your patch doesn't apply cleanly to master.

    I changed the patch to make it apply cleanly. I would post it here, but two tests are failing once the p...