Kurt Stephens's profile

Kurt Stephens commented at 12:21 AM
The IPv6 portion of the regexp may also be in error.

Kurt Stephens commented at 9:47 PM

A naive search yields other potential errors/problems:

actionpack-3.0.3/lib/action_dispatch/http/request.rb:170:    TRUSTED_PROXIES = /^127\.0\.0\.1$|^(10|172\...

Kurt Stephens commented at 6:39 AM
Unless I'm completely mistaken -- The E'' prefix has nothing to do with this bug. The E'' prefix is the extended escape sequence that Postgresql-8.3 (and up) su...

Kurt Stephens commented at 8:32 AM
To fix this for your calling sequence would require removal of the "reload" magic. IMO, the reload magic is a really bad API idea, but it would require everyone...

Kurt Stephens commented at 8:05 AM

This is why:

            def #{symbol}(*args)                                                   #   def mime_type(*args)
              #{memoized_ivar} ||= {} ...

Kurt Stephens commented at 6:34 AM
The elements in args are not protected from side-effects either so something like:
```
  a = [ 1, 2 ]
  puts memoized_method(a)
  a[0] = 5
  puts memoized_method(a...
```
Kurt Stephens commented at 6:29 AM
There also a problem if method being memoized is named "memoized". :) The "memoized" local variable in the code template should be gensym'ed.

Kurt Stephens commented at 6:28 AM

Also, should:

memoized = @_memoized_#{symbol} || ::ActiveSupport::ConcurrentHash.new

be:

memoized = (@_memoized_#{symbol} ||= ::ActiveSupport::ConcurrentHash...

Kurt Stephens commented at 6:26 AM

Here's fix for activesupport/lib/active_support/memoizable.rb:

module ActiveSupport
  module SafelyMemoizable
    def safely_memoize(*symbols)
      symbols.ea...