Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

hsume2 (Henry)'s latest activity

Sunday, September 27 2009
3005 :counter_cache not updated if polymorphic => true when assigning association was updated in Ruby on Rails
  • hsume2 (Henry)
    hsume2 (Henry) commented at 11:15 AM

    Made a mistake assigning tagging. I've reattached the fixed test.

  • hsume2 (Henry)
    hsume2 (Henry) commented at 6:20 AM

    +1, verified on 2-3-stable and master.

    Good job on the test! However, the Tagging and Post models already encompass the belongs to polymorphic association. Also...

3149 Active Record Helper form(record_name, options={}) fails (but simple fix) was updated in Ruby on Rails
  • hsume2 (Henry)
    hsume2 (Henry) commented at 10:28 AM

    +1, verified in master and 2-3-stable. (master patch applies cleanly to both)

3138 [PATCH] ActiveSupport::Memoizable - flush_cache fails for methods ending in ? was updated in Ruby on Rails
  • hsume2 (Henry)
    hsume2 (Henry) commented at 4:56 AM

    +1 patched applied cleanly on master and 2-3-stable

Saturday, September 26 2009
3108 Eager loading uniq habtm association is broken was updated in Ruby on Rails
  • hsume2 (Henry)
    hsume2 (Henry) commented at 10:38 AM

    Also, this is my take on patching the issue. I thought of adding something like (-190,6 +190,7):

    +  associated_records.uniq! if options[:uniq]
       set_associati...
  • hsume2 (Henry)
    hsume2 (Henry) commented at 10:07 AM

    -1 changing the developers.yml somehow introduced failures in other tests.

    I rewrote it using dev_3 instead. I've attached the edited failing test.

2995 nullifying doesn't work with SQLite3 was updated in Ruby on Rails
  • hsume2 (Henry)
    hsume2 (Henry) commented at 8:13 AM

    +1 confirmed in 2-3-stable

    I'm pretty positive it has something to do with the class being called Migration, also, it's not just dependent associations. Simply ...

3218 default_scope is having a side affecct on create was updated in Ruby on Rails
  • hsume2 (Henry)
    hsume2 (Henry) commented at 1:48 AM

    Sorry, I don't mean conflict.. exactly. More like, the behavior is different from that in #test_default_values_on_empty_strings.

  • hsume2 (Henry)
    hsume2 (Henry) commented at 1:47 AM

    I think I get what you've done. However, I think your implementation conficts with #test_default_values_on_empty_strings in base_test.rb. I've attached a patch ...

Friday, September 25 2009
3218 default_scope is having a side affecct on create was updated in Ruby on Rails
  • hsume2 (Henry)
    hsume2 (Henry) commented at 6:05 PM

    verified on 2-3-stable

    I've attached a failing test.