hsume2 (Henry)
Not a member
hsume2 (Henry)'s latest activity
Sunday, September 27 2009
-
hsume2 (Henry) commented at 11:15 AMMade a mistake assigning
tagging. I've reattached the fixed test. -
hsume2 (Henry) commented at 6:20 AM+1, verified on 2-3-stable and master.
Good job on the test! However, the
TaggingandPostmodels already encompass the belongs to polymorphic association. Also...
-
hsume2 (Henry) commented at 10:28 AM+1, verified in master and 2-3-stable. (master patch applies cleanly to both)
Saturday, September 26 2009
-
hsume2 (Henry) commented at 10:38 AMAlso, this is my take on patching the issue. I thought of adding something like (-190,6 +190,7):
+ associated_records.uniq! if options[:uniq] set_associati... -
hsume2 (Henry) commented at 10:07 AM-1 changing the
developers.ymlsomehow introduced failures in other tests.I rewrote it using
dev_3instead. I've attached the edited failing test.
-
hsume2 (Henry) commented at 8:13 AM+1 confirmed in 2-3-stable
I'm pretty positive it has something to do with the class being called
Migration, also, it's not just dependent associations. Simply ...
-
hsume2 (Henry) commented at 1:48 AMSorry, I don't mean conflict.. exactly. More like, the behavior is different from that in #test_default_values_on_empty_strings.
-
hsume2 (Henry) commented at 1:47 AMI think I get what you've done. However, I think your implementation conficts with #test_default_values_on_empty_strings in base_test.rb. I've attached a patch ...