hsume2 (Henry)'s profile

hsume2 (Henry) commented at 10:04 PM
Okay, that's pretty weird. Well thanks anyway.
hsume2 (Henry) commented at 9:03 PM
@Neeraj, I'm not sure why either. I've applied the patch multiple times today at different commits, most recently on [387036609268c4cf68401a1333715f2ee4aecffc],...
hsume2 (Henry) commented at 6:15 PM
Sure, here are the patches created from rails root.

hsume2 (Henry) commented at 7:29 PM
I've attached reworked patches for master and 2-3-stable. The implementation is slightly different than previously specified. Instead of
```
associated_records.uni...
```

- Tag changed from 2.3.3, activerecord, bugmash to 2.3.3, activerecord, bugmash, bugmash-review
by hsume2 (Henry) at 10:25 AM

hsume2 (Henry) commented at 6:38 PM

1. There is not test that checks counter_cache changes with the append (<<) operand on has_many relation.

I agree, counter_cache updating is unbalanced, espe...

hsume2 (Henry) commented at 4:49 PM
+1 for reserved words list, especially for the case of nested, existing resources, since we wouldn't want anyone doing:
```
class Object < ActiveResource::Base
end...
```
hsume2 (Henry) commented at 3:59 PM
sorry, changed address to object
hsume2 (Henry) commented at 3:54 PM

verified on master and 2-3-stable

I've attached a patch; failing test for master (cherry picks into 2-3-stable) as well a patch for 2-3-stable.

hsume2 (Henry) commented at 3:13 PM
+1, verified both patches apply successfully