Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

andyjeffries

andyjeffries

Not a member

andyjeffries's latest activity

Friday, March 05 2010
3988 [PATCH] Deprecate public_path and create 'public' method that returns a Pathname was updated in Ruby on Rails
  • andyjeffries
    andyjeffries commented at 3:30 PM

    OK, never mind - he's probably done a better job than me anyway (mine still wasn't working).

    Did you ever speak to the Core guys to see if they wanted public_pa...
Friday, February 26 2010
3988 [PATCH] Deprecate public_path and create 'public' method that returns a Pathname was updated in Ruby on Rails
  • andyjeffries
    andyjeffries commented at 1:37 PM

    If you're willing to offer help to a new developer like this, it might be better to take it to email/MSN rather than fill up lighthouse with it. My email addres...
  • andyjeffries
    andyjeffries commented at 1:32 PM

    Oh man alive, this is turning out in to quite a job for my first little patch to dip my toes in!

    I'll have a bit of a deeper look at this problem next week then...
  • andyjeffries
    andyjeffries commented at 1:15 PM

    José Thanks for that, I guess it's a hint rather than the whole solution, but I can't tell how to apply it to AssetTagHelper?

    The helpers are all autoloaded, so...
  • andyjeffries
    andyjeffries commented at 1:05 PM

    It appears the metal failures (which now it becomes important I'll list them - test_multiple_metal_endpoints and test_single_metal_endpoint) are me as a vanilla...
  • andyjeffries
    andyjeffries commented at 12:57 PM

    I've tried to rework the patch, but I fail. The tests all pass except for a couple of metal ones (where it seems to return the index.html content - not sure tha...
1 earlier change…
  • andyjeffries
    andyjeffries commented at 11:01 AM

    Sure José, I want to start contributing to Rails so I'll definitely try it the new way. I'll have a go at whipping something up today. Thanks for the hints.
Monday, February 22 2010
3639 has_and_belongs_to_many documentation fix was updated in Ruby on Rails
  • andyjeffries
    andyjeffries commented at 2:18 PM

    +1 Good spot, applies cleanly
3902 Fix spelling of 'features' in ActiveModel documentation was updated in Ruby on Rails
  • andyjeffries
    • Tag changed from doc to doc, patch
    by andyjeffries at 2:14 PM

    +1 Applies cleanly, simple enough patch
Thursday, February 18 2010
3988 [PATCH] was created in Ruby on Rails
  • andyjeffries
    andyjeffries created the ticket at 8:26 AM

    Having got quite used to Rails.root returning a Pathname object to allow easy concatenation of paths, I noticed that Rails.public_path doesn't. I checked in 2.3...