David Trasbo
Ruby on Rails developer · Member of 1 project: Ruby on Rails
David Trasbo's latest activity
Monday, October 11 2010
-
David Trasbo commented at 6:57 PMAh, ok. Silly me, didn't think about that!
Anyways: +1
Patch applies cleanly and tests pass. Please do unify all the commits in the patch, though.
-
- State changed from incomplete to open
Jarl,
Actually a ticket is incomplete if there's no patch. If a ticket is missing info on how to reproduce the problem, it will be marked
needs-more-info.
-
David Trasbo commented at 6:47 PMThat is indeed another bug. If the docs state that something is deprecated, it is. Warning or no warning. In this case I think not throwing a warning was chosen...
Sunday, October 10 2010
-
- State changed from new to open
- Importance changed from to Low
+1
I'd even say that
cookiesnot being indifferent access is unexpected behavior.David, are you still planning on making a patch for this? I'd be happy to.
-
- State changed from needs-more-info to wontfix
My personal opinion: -1
Why not just use if statements instead?
if Rails.env.development? # ... end if Rails.env.production? # ... end # So on, so forth...
-
- State changed from new to open
- Importance changed from to Low
+1
Though I'd suggest it to be done through the new
ActiveSupport::Notificationssystem.
-
-
David Trasbo commented at 5:59 PMSantiago,
Same as #3431 - except it's a very minor change. I think you should just go ahead and apply this. If you have time?
-
David Trasbo commented at 6:08 PMSorry, José. I can see my intent was unclear, but I just wanted to take some load off your shoulders. You seem to have a lot to do at the moment. Again, sorry.