Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

David Trasbo's latest activity

Monday, October 11 2010
5724 Subclasses of HashWithIndifferentAccess dup the wrong class was updated in Ruby on Rails
  • David Trasbo
    David Trasbo commented at 6:57 PM

    Ah, ok. Silly me, didn't think about that!

    Anyways: +1

    Patch applies cleanly and tests pass. Please do unify all the commits in the patch, though.

5765 ActionMailer fails with exception_notification was updated in Ruby on Rails
  • David Trasbo
    • State changed from incomplete to open
    by David Trasbo at 6:50 PM

    Jarl,

    Actually a ticket is incomplete if there's no patch. If a ticket is missing info on how to reproduce the problem, it will be marked needs-more-info.

5749 ActionMailer::Base.default_url_options are not actually deprecated was updated in Ruby on Rails
  • David Trasbo
    David Trasbo commented at 6:47 PM

    That is indeed another bug. If the docs state that something is deprecated, it is. Warning or no warning. In this case I think not throwing a warning was chosen...

Sunday, October 10 2010
5735 Weird classes namespace whith cache_classes = false was updated in Ruby on Rails
  • David Trasbo
    • State changed from incomplete to open
    by David Trasbo at 8:29 PM
5761 cookies hash in ActionDispatch::TestProcess should be indifferent access was updated in Ruby on Rails
  • David Trasbo
    • State changed from new to open
    • Importance changed from to Low
    by David Trasbo at 6:28 PM

    +1

    I'd even say that cookies not being indifferent access is unexpected behavior.

    David, are you still planning on making a patch for this? I'd be happy to.

4908 [feature-request] db seed files for each environment. was updated in Ruby on Rails
  • David Trasbo
    • State changed from needs-more-info to wontfix
    by David Trasbo at 6:25 PM

    My personal opinion: -1

    Why not just use if statements instead?

    if Rails.env.development?
     # ...
    end
    
    if Rails.env.production?
      # ...
    end
    
    # So on, so forth
    

    ...

5712 activerecord connection established event was updated in Ruby on Rails
  • David Trasbo
    • State changed from new to open
    • Importance changed from to Low
    by David Trasbo at 6:16 PM

    +1

    Though I'd suggest it to be done through the new ActiveSupport::Notifications system.

5555 actionmailer 2.3.9 should now require 'uri' was updated in Ruby on Rails
  • David Trasbo
    David Trasbo commented at 6:09 PM

    José, same as #3431.

  • David Trasbo
    David Trasbo commented at 5:59 PM

    Santiago,

    Same as #3431 - except it's a very minor change. I think you should just go ahead and apply this. If you have time?

3431 ActionMailer does not return correctly to respond_to? with deliver_ prefix was updated in Ruby on Rails
  • David Trasbo
    David Trasbo commented at 6:08 PM

    Sorry, José. I can see my intent was unclear, but I just wanted to take some load off your shoulders. You seem to have a lot to do at the moment. Again, sorry.