This project is archived and is in readonly mode.

#5555 ✓resolved
Hans de Graaff

actionmailer 2.3.9 should now require 'uri'

Reported by Hans de Graaff | September 5th, 2010 @ 10:02 AM | in 2.3.10

The actionmailer 2.3.9 tests failed for me when running against actionpack 2.3.9:

/usr/bin/ruby18 -I"lib:test" "/usr/lib64/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb" "test/asset_host_test.rb" "test/delivery_method_test.rb" "test/mail_helper_test.rb" "test/mail_layout_test.rb" "test/mail_render_test.rb" "test/mail_service_test.rb" "test/quoting_test.rb" "test/test_helper_test.rb" "test/tmail_test.rb" "test/url_test.rb" 
/usr/lib64/ruby/gems/1.8/gems/activesupport-2.3.9/lib/active_support/dependencies.rb:466:in `load_missing_constant': uninitialized constant ActionController::UrlWriter::URI (NameError)
    from /usr/lib64/ruby/gems/1.8/gems/activesupport-2.3.9/lib/active_support/dependencies.rb:106:in `const_missing'
    from /usr/lib64/ruby/gems/1.8/gems/actionpack-2.3.9/lib/action_controller/url_rewriter.rb:96
    from /var/tmp/portage/dev-ruby/actionmailer-2.3.9/work/ruby18/actionmailer-2.3.9/lib/action_mailer/base.rb:250
    from ./test/abstract_unit.rb:21
    from /usr/lib64/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `gem_original_require'
    from /usr/lib64/ruby/site_ruby/1.8/rubygems/custom_require.rb:31:in `require'
    from ./test/asset_host_test.rb:1
    from /usr/lib64/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:5:in `load'
    from /usr/lib64/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:5
    from /usr/lib64/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:5:in `each'
    from /usr/lib64/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb:5
rake aborted!
Command failed with status (1): [/usr/bin/ruby18 -I"lib:test" "/usr/lib64/r...]

This happens because http://github.com/rails/rails/commit/f8f4872fccbc6ba2b4970e4e9eab9c... now adds a dependency on URI that is not accounted for in actionmailer. I've include a patch to fix this, but I'm not sure if this is where you'd want the require to be.

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Attachments

Referenced by

Pages