actionmailer 2.3.9 should now require 'uri'

Hi Hans. I don't see your patch attached to this ticket.

Oops. Patch attached.

@David: I think that if the tests aren't running then isn't them then running enough? What in the guidelines has he missed?

@OP: For additional points: Is it just rake test and it breaks from within actionmailer? Nothing else magical?

Hans and Ryan,

Perhaps I could have been more clear. :)

What's missing is to format the patch using format-patch to include commit message, author, etc.

This bug prevented our app from bootstrapping when we upgraded to 2.3.9, possibly because of load order, so it's not just a test issue. Can the priority be made higher, please?

I won't be adding a patch according to the guidelines, because I'm not convinced that this is the right approach to fixing it, even if it fixes the symptom. I'd rather see the owners of those components decide what the best way to fix this is. I've included my original patch to indicate exactly where the symptom surfaces.

Hans, the correct approach to fixing it would be to put this require at the top of actionmailer/lib/action_mailer/base.rb with the other requires. Please write a patch to do this so that it is attributed to you.

I had opened a duplicate ticket for this -- #5760 Missing require in action_controller/url_rewriter -- and Ryan Bigg asked me to attach my patch to this one.

My patch adds require 'uri' to the top of action_controller/url_rewriter, which is where it ultimately belongs, because this is the file that depends on URI, not action_mailer/base.

I consider this a high priority fix -- the framework won't boot correctly if you configure ActionMailer in your environment. In my case, I was configuring ActionMailer only in my production environment, which meant I deployed code (after upgrading to Rails 2.3.9) that worked in development and test, but wouldn't boot in production.

I agree that it is much better to fix this issue in ActionController instead.

Ok, I inspected my app a little more and realized that I was doing something unconventional -- I was setting ActionMailer settings in config/environments/production.rb directly on the constant, like so:

ActionMailer::Base.smtp_settings = {
  # settings
}

instead of the correct way for environment files:

config.action_mailer.smtp_settings = {
  # settings
}

Additionally, I was opting out of ActiveResource, which requires 'uri':

config.active_resource -= [:active_resource]

This non-conventional config + ActiveResource opt-out is probably why this issue has not been discovered by more users.

So, not as high-priority an issue as I first thought, though this should still be fixed.

Santiago,

Same as #3431 ActionMailer does not return correctly to respond_to? with deliver_ prefix - except it's a very minor change. I think you should just go ahead and apply this. If you have time?

José, same as #3431 ActionMailer does not return correctly to respond_to? with deliver_ prefix.