Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Rizwan Reza's latest activity

Sunday, August 09 2009
2558 Support for :joins in ActiveRecord::Base#update_all was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 6:13 PM

    verified

    +1 The patch works only on 2-3-stable. All tests pass.

1878 a generated plugin's tests are not run by 'rake test' was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 5:58 PM

    verified

    +1 The last patch works in master.

2707 dbconsole support password passing through /dev/fd/ was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 5:53 PM

    not reproducible

    -1 Both patches fail.

2544 Can't set Mysql timeouts was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 5:04 PM

    verified

    This works... but a test would be great.

3020 ActiveResource#exists? does not work at all was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:53 PM

    verified

    +1 Both patches work correctly.

2048 undefined method `quoted_table_name' with model called "schema" was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:43 PM

    not reproducible

    -1 It is evident that ActiveRecord will have problems with tables that have matching names to its internal classes.

2973 Add options passing to textilze helper was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:33 PM

    Applies cleanly on my side. Just rechecked.

2126 HTTP_X_FORWARDED_FOR ignored if REMOTE_ADDR is "trusted" was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:30 PM

    verified

    +1 The second patch applies cleanly to master and tests also pass. Good work!

2353 helper caching issue was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:23 PM

    not reproducible

    -1 Agreed with Nick. The problem lies in defining that pretty_datetime. Invalid.

2316 [PATCH] 410 Gone as ResourceGone for ActiveResource was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:19 PM

    verified

    +1 The patch by Jatinder applies to 2-3-stable only. All tests pass.