Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Rizwan Reza

Rizwan Reza

Member of 1 project: Ruby on Rails

Rizwan Reza's latest activity

Sunday, August 09 2009
1742 [PATCH] serialize fails when :null => false was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:16 PM

    verified

    +1 The patch applies cleanly though, there are no tests.
3012 test tasks fail when db/schema.rb doesn't exist was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:14 PM

    verified

    +1 The patch applies cleanly to master and 2-3-stable.
973 JSON parser fails to read escaped backslashes was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:11 PM

    verified

    +1 Both patches apply cleanly to the respective branches. All tests pass.
1715 AR:Base mangles dates when user submits only part of the fields was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:06 PM

    verified

    This patch applies cleanly to 2-3-stable. All tests pass.
2973 Add options passing to textilze helper was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:03 PM

    verified

    By the way, though nzkoz suggests that this should be applied to master.. this passes cleanly on 2-3-stable too.
2126 HTTP_X_FORWARDED_FOR ignored if REMOTE_ADDR is "trusted" was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 4:01 PM

    verified

    +1 This patch applies cleanly to 2-3-stable. All tests pass.
2630 Adding a validates_with method was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 3:58 PM

    verified

    +1 This patch works cleanly on master. Safe to commit.
2653 validates_uniqueness_of unicode aware field length was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 3:51 PM

    not reproducible

    -1 The patch fails on master.

    Created an event whose title, with limit taken into account, is not unique.
<false> is not true.
1762 [PATCH] Possible rendering bug on label_tag vs. radio_button_tag was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 3:45 PM

    I think it should not break the compatibility if only label_tag changes. The main problem is that the label tag isn't 'attaching' properly to the radio tag, and...
3023 Removed unused routing method was updated in Ruby on Rails
  • Rizwan Reza
    Rizwan Reza commented at 3:43 PM

    verified

    +1 This patch works perfectly on both current branches. But I am not sure if all of the tests pass, the method is useless, as there are methods present...