Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Derander

Derander

Not a member

Derander's latest activity

Monday, August 10 2009
1683 Custom counter caches not being used was updated in Ruby on Rails
  • Derander
    • Tag changed from activerecord, patch to activerecord, patch
    by Derander at 8:47 AM

    Jose Valim found an error in my understanding of the patch.

    The problem is not found by examining the value of p.custom_count, instead, starting from p.save:

    p....
2493 Eager Loading With :limit Returns Wrong Result Set (MySQL) was updated in Ruby on Rails
  • Derander
    Derander commented at 7:53 AM

    +1 verified.

    The patches above apply & fail on latest master.
2151 routing not recognizing requirements for :format was updated in Ruby on Rails
  • Derander
    Derander commented at 7:44 AM

    +1 verified, applies to master.

    I read the test, looks like it is testing the right thing. I'll look into a patch.
1367 [PATCH] Perform caching=false should not perform caching was updated in Ruby on Rails
  • Derander
    Derander commented at 7:37 AM

    +1, this seems like an appropriate change. Shouldn't break backwards compatibility.

    Applies cleanly to latest master & tests pass.
597 "bös".chars.reverse is "s̈ob" for decomposed string was updated in Ruby on Rails
  • Derander
    Derander commented at 7:18 AM

    +1 verified on master, this also happens w/ the string "bés"
1249 [PATCH] New Feature - grouped_collection_select was updated in Ruby on Rails
  • Derander
    Derander commented at 7:07 AM

    +1 verified patch applies to master.

    This is a good idea, API consistency is A Good Thing™.
2049 to_xml nil => true attribute should not appear when I skip types was updated in Ruby on Rails
  • Derander
    Derander commented at 7:02 AM

    -1, verified behavior in 2-3-stable... I agree with Dan. I think that :skip_nils is a good idea Hugo, but it would probably be better as a new ticket.
Sunday, August 09 2009
2732 [PATCH] deep_merge does not work on HashWithIndifferentAccess was updated in Ruby on Rails
  • Derander
    Derander commented at 11:41 PM

    I don't think a mixin is needed because HashWithIndiff inherits from Hash.

    Anyways, here is an alternate implementation of the above patch where it replaces Has...
  • Derander
    Derander commented at 11:03 PM

    Here is my patch applied for master.
1683 Custom counter caches not being used was updated in Ruby on Rails
  • Derander
    Derander commented at 9:52 PM

    To verify the fix,

    rails test2

    cd test2

    script/generate model Post title:string custom_count:integer

    script/generate model Comment title:string post_id:integer

    ...