Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Adam Keys

Adam Keys

Not a member

Adam Keys's latest activity

Saturday, August 08 2009
2981 validates_length_of should exclude last member of an end-excluding range was updated in Ruby on Rails
  • Adam Keys
    Adam Keys commented at 11:10 PM

    Reworked patch per Jose's comments.
  • Adam Keys
    Adam Keys commented at 6:43 PM

    The patch above appears to apply to master, unless I'm missing something. I've attached a patch that applies to 2-3-stable and verified it.
2660 InstanceTag to_label_tag id attribute was updated in Ruby on Rails
  • Adam Keys
    Adam Keys commented at 5:26 PM

    I've verified this applies cleanly to 2-3-stable. Test coverage looks good. +1
2269 Enumerable#sum not called on some association collections was updated in Ruby on Rails
  • Adam Keys
    Adam Keys commented at 5:01 PM

    Will, I'm wondering if changing some_has_many.sum to load all records is too sugary. Case in point, I can look at this and think "hey, this is obviously loading...