Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Eric Chapweske's latest activity

Saturday, January 30 2010
3178 Mass Assignment Security Refactoring was updated in Ruby on Rails
  • Eric Chapweske
    Eric Chapweske commented at 2:10 AM

    Bleh, scratch that -- this patch has a bug in it -- but I expect the style is correct :)

  • Eric Chapweske
    Eric Chapweske commented at 1:57 AM

    Woops. Adding indentation for private/protected and no spaces between modules and classes.

Friday, January 29 2010
3178 Mass Assignment Security Refactoring was updated in Ruby on Rails
  • Eric Chapweske
    Eric Chapweske commented at 3:37 AM

    Oh, this patch also modifies the documentation. Removed advise about using Hash.slice, and replaced it with this:

    # Note that using <tt>Hash#except</tt> or <tt...
  • Eric Chapweske
    Eric Chapweske commented at 3:36 AM

    New patch against master.

Monday, January 25 2010
3348 Refactoring of attributes/typecasting behavior was updated in Ruby on Rails
  • Eric Chapweske
    Eric Chapweske commented at 5:20 PM

    Hey guys,

    What's the performance goal for this?

    Current results: reading attributes is now 3x slower, though a couple methods are a fair bit faster. (query_attr...

Tuesday, January 12 2010
3178 Mass Assignment Security Refactoring was updated in Ruby on Rails
  • Eric Chapweske
    Eric Chapweske commented at 8:18 PM

    Any chance of this making it in the next release? Hoping to utilize this in the near future.

    Thanks!
    -Eric

Saturday, October 17 2009
3387 Decimal attributes no longer work on Rails 3.0 edge was updated in Ruby on Rails
  • Eric Chapweske
    Eric Chapweske commented at 10:59 PM

    This was due to *before_typecast permanently disabling typecasting. Attached is the fix. Decimals not covered under the spec is a problem too. I'll go through a...

3348 Refactoring of attributes/typecasting behavior was updated in Ruby on Rails
  • Eric Chapweske
    Eric Chapweske commented at 2:21 AM

    Sorry, I created that last patch without the tests. This is the complete version.

  • Eric Chapweske
    Eric Chapweske commented at 1:55 AM

    Woops, this new one should apply.

Thursday, October 08 2009
3348 Refactoring of attributes/typecasting behavior was created in Ruby on Rails
  • Eric Chapweske
    Eric Chapweske created the ticket at 7:25 AM

    Decouples the attribute/typecasting implementation, introducing an Attributes:Store and ActiveRecord::Types. I think this simplifies things and lays the groundw...